8000 [release/v7.3.0-rc.1] Add XML reference documents to NuPkg files for SDK by github-actions[bot] · Pull Request #18017 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

[release/v7.3.0-rc.1] Add XML reference documents to NuPkg files for SDK #18017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2022
Merged

[release/v7.3.0-rc.1] Add XML reference documents to NuPkg files for SDK #18017

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1838a67
Add xml documentation to all ref folders
adityapatwardhan Aug 30, 2022
563a7a2
Fix bin path
adityapatwardhan Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tools/packaging/packaging.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2108,7 +2108,7 @@ function New-ILNugetPackageSource

#region ref
$refFolder = New-Item (Join-Path $filePackageFolder.FullName "ref/$script:netCoreRuntime") -ItemType Directory -Force
CopyReferenceAssemblies -assemblyName $fileBaseName -refBinPath $refBinPath -refNugetPath $refFolder -assemblyFileList $fileList
CopyReferenceAssemblies -assemblyName $fileBaseName -refBinPath $refBinPath -refNugetPath $refFolder -assemblyFileList $fileList -winBinPath $WinFxdBinPath
#endregion ref

$packageRuntimesFolderPath = $packageRuntimesFolder.FullName
Expand Down Expand Up @@ -2257,7 +2257,8 @@ function CopyReferenceAssemblies
[string] $assemblyName,
[string] $refBinPath,
[string] $refNugetPath,
[string[]] $assemblyFileList
[string[]] $assemblyFileList,
[string] $winBinPath
)

$supportedRefList = @(
Expand Down Expand Up @@ -2286,7 +2287,8 @@ function CopyReferenceAssemblies
default {
$ref_SMA = Join-Path -Path $refBinPath -ChildPath System.Management.Automation.dll
$ref_doc = Join-Path -Path $refBinPath -ChildPath System.Management.Automation.xml
Copy-Item $ref_SMA, $ref_doc -Destination $refNugetPath -Force
$self_ref_doc = Join-Path -Path $winBinPath -ChildPath "$assemblyName.xml"
Copy-Item $ref_SMA, $ref_doc, $self_ref_doc -Destination $refNugetPath -Force
Write-Log "Copied file '$ref_SMA' and '$ref_doc' to '$refNugetPath'"
}
}
Expand Down
0