8000 Allow multiple installations of dotnet. by JamesWTruher · Pull Request #17141 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Allow multiple installations of dotnet. #17141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2022
Merged

Allow multiple installations of dotnet. #17141

merged 2 commits into from
Apr 12, 2022

Conversation

JamesWTruher
Copy link
Collaborator

A new flag for removal is now provided, but by default we will add a new version of dotnet.

PR Summary

This adds the proper flag to not damage a new installation of dotnet if one exists.
Additionally, we will no longer automatically delete previous versions of dotnet. Previous versions of dotnet may still be removed by using the new -RemovePreviousVersion parameter of Install-Dotnet

PR Context

Current install-dotnet will break dotnet use if another version already exists. This PR adds the -skipnonversionedfiles parameter when calling dotnet-install which avoids this behavior.

PR Checklist

@ghost ghost assigned PaulHigin Apr 12, 2022
@TravisEz13
Copy link
Member

We should consider this for backport to avoid extra work in fixing local mac dev machines, but we should get at least one preview release.

@JamesWTruher
Allow multiple installations of dotnet.
095e203 
A new flag for removal is now provided, but by default we will add a new version of dotnet.
@pull-request-quantifier-deprecated
Copy link

This PR has 29 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +17 -12
Percentile : 11.6%

Total files changed: 2

Change summary by file extension:
.psm1 : +14 -9
.json : +3 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

PaulHigin
PaulHigin suggested changes Apr 12, 2022
View reviewed changes
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 12, 2022
@PaulHigin PaulHigin merged commit 9c13c04 into PowerShell:master Apr 12, 2022
@JamesWTruher JamesWTruher deleted the FixDotnetInstall01 branch April 12, 2022 21:35
JamesWTruher added a commit to JamesWTruher/PSScriptAnalyzer that referenced this pull request Apr 12, 2022
@JamesWTruher
Be sure not to clobber existing files when installing dotnet.
a6c880f 
This is the same fix as PowerShell/PowerShell#17141
@JamesWTruher JamesWTruher mentioned this pull request Apr 12, 2022
Merged
6 tasks
@TravisEz13
Copy link
Member

/backport to release/v7.2.4

@github-actions
Copy link
Contributor
github-actions bot commented Apr 28, 2022 •
edited by unfurl-links bot
Loading

Started backporting to release/v7.2.4: https://github.com/PowerShell/PowerShell/actions/runs/2242321819

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions github-actions bot mentioned this pull request Apr 28, 2022
Merged
1 task
@JamesWTruher JamesWTruher removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 5, 2022
@TravisEz13
Copy link
Member

/backport to release/v7.0.11

@github-actions
Copy link
Contributor
github-actions bot commented May 9, 2022 •
edited by unfurl-links bot
Loading

Started backporting to release/v7.0.11: https://github.com/PowerShell/PowerShell/actions/runs/2295866950

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions
Copy link
Contributor
github-actions bot commented May 9, 2022

@TravisEz13 backporting to release/v7.0.11 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Allow multiple installations of dotnet.
Using index info to reconstruct a base tree...
M	build.psm1
Falling back to patching base and 3-way merge...
Auto-merging build.psm1
CONFLICT (content): Merge conflict in build.psm1
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow multiple installations of dotnet.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@TravisEz13
Copy link
Member

Have Jim do the backport once we open the 7.0.12 branch. This is not required.

@ghost
Copy link
ghost commented May 23, 2022

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

JamesWTruher added a commit to PowerShell/PSScriptAnalyzer that referenced this pull request May 23, 2022
@JamesWTruher
Be sure not to clobber existing files when installing dotnet. (#1788)
e6019da 
This is the same fix as PowerShell/PowerShell#17141
@adityapatwardhan
Copy link
Member

/backport to release/v7.0.12

@adityapatwardhan
Copy link
Member

Not needed for release. This makes working on mac easier, no effect during the release process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@PaulHigin PaulHigin PaulHigin approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@PaulHigin PaulHigin

Labels
Backport-7.2.x-Done Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamesWTruher @TravisEz13 @adityapatwardhan @PaulHigin
0