8000 Remove declaration of experimental features in Utility module manifest as they are stable by SteveL-MSFT · Pull Request #16460 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Remove declaration of experimental features in Utility module manifest as they are stable #16460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2021
Merged

Remove declaration of experimental features in Utility module manifest as they are stable #16460

merged 3 commits into from
Dec 7, 2021

Conversation

SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Nov 12, 2021 •
edited by anmenaga
Loading

PR Summary

Fix Utility module manifest to not advertise stable features incorrectly identified as experimental

PR Context

Per #15864 the module manifest wasn't updated along with the code

PR Checklist

@ghost ghost assigned anmenaga Nov 12, 2021
@iSazonov iSazonov mentioned this pull request Nov 13, 2021
Closed
18 tasks
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 21, 2021
@ghost
Copy link
ghost commented Nov 21, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide 8000 feedback and/or mark it as Waiting on Author

@pull-request-quantifier-deprecated
Copy link

This PR has 20 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +0 -20
Percentile : 8%

Total files changed: 2

Change summary by file extension:
.psd1 : +0 -20

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan
Copy link
Member

@daxian-dbw - please re-review.

/cc @anmenaga - we should consider this for next release.

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 1, 2021
@anmenaga anmenaga merged commit 4f54655 into PowerShell:master Dec 7, 2021
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 8, 2021
@ghost
Copy link
ghost commented Dec 14, 2021

🎉v7.2.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link
ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@SteveL-MSFT SteveL-MSFT deleted the utility-experiment branch January 3, 2022 23:01
TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@SteveL-MSFT @TrapGodBrim
Remove declaration of experimental features in Utility module manifes…
7867895 
…t as they are stable (PowerShell#16460)
@unfurl-links unfurl-links bot mentioned this pull request Feb 7, 2022
Closed
5 tasks
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 9, 2022
@SteveL-MSFT
Remove declaration of experimental features in Utility module manifes…
80c5dde 
…t as they are stable (PowerShell#16460)
@TravisEz13 TravisEz13 mentioned this pull request May 24, 2022
Merged
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6A71
Reviewers

@iSazonov iSazonov iSazonov left review comments

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees

@anmenaga anmenaga

Labels
Backport-7.2.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SteveL-MSFT @adityapatwardhan @daxian-dbw @iSazonov @TravisEz13 @anmenaga
0