Update license and cgmanifest #16325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
reviewed
Oct 28, 2021
"Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below).
Member
There was a problem hiding this comment.
Are the white spaces like those here intended to have?
Member
There was a problem hiding this comment.
This is an autogenerated file. I don't have code to remove trailing spaces. I think @adityapatwardhan who updated this last, probably updated in vscode and has the option to remove trailing spaces on.
github-actions
bot
requested review from
adityapatwardhan and
anmenaga
as code owners
October 28, 2021 19:39
This PR has 163 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!
Quantification details
Label : Medium
Size : +139 -24
Percentile : 52.6%
Total files changed: 5
Change summary by file extension:
.yml : +18 -12
.txt : +1 -0
.json : +120 -12
Change counts above are quantified counts, based on the PullRequestQuantifier customizations.
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:
- Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
iterations.
- Similarity in low PR complexity drives similar review times.
- Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detetcted.
- Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
- Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.
What can I do to optimize my changes
- Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the
Excluded section from your prquantifier.yaml context profile.
Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your
prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
- Your PR could be split in smaller, self-contained PRs instead
- Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).
How to interpret the change counts in git diff output
- One line was added:
+1 -0
- One line was deleted:
+0 -1
- One line was modified:
+1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
- Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.
daxian-dbw
approved these changes
Oct 28, 2021
Member
@TravisEz13 @adityapatwardhan I will merge once one of you approve this PR.
Member
Also, @TravisEz13 can you label the PR with 7.2.0-backport-xxx as you see needed?
adityapatwardhan
approved these changes
Oct 28, 2021
adityapatwardhan
added
Backport-7.2.x-Approved
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
Backport-7.2.x-Done
and removed
Backport-7.2.x-Consider
labels
Oct 30, 2021
🎉v7.2.0 has been released which incorporates this pull request.:tada:
Handy links:
🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:
Handy links:
TrapGodBrim
pushed a commit
to TrapGodBrim/PowerShell
that referenced
this pull request
Jan 19, 2022
daxian-dbw
pushed a commit
to daxian-dbw/PowerShell
that referenced
this pull request
Mar 9, 2022
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
| "Work" shall mean the work of authorship, whether in Source or Object form, made available under the License, as indicated by a copyright notice that is included in or attached to the work (an example is provided in the Appendix below). | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Are the white spaces like those here intended to have?
There was a problem hiding this comment.
This is an autogenerated file. I don't have code to remove trailing spaces. I think @adityapatwardhan who updated this last, probably updated in vscode and has the option to remove trailing spaces on.
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
@TravisEz13 @adityapatwardhan I will merge once one of you approve this PR. |
|
Also, @TravisEz13 can you label the PR with |
|
🎉 Handy links: |
|
🎉 Handy links: |
Automated changes by create-pull-request GitHub action