8000 Add `cgmanifest.json` for generating correct third party notice file by adityapatwardhan · Pull Request #16266 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add cgmanifest.json for generating correct third party notice file #16266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 2 commits into from
Oct 19, 2021
Merged

Add cgmanifest.json for generating correct third party notice file #16266

daxian-dbw merged 2 commits into from
Oct 19, 2021

Conversation

@adityapatwardhan
Copy link
Member
@adityapatwardhan adityapatwardhan commented Oct 18, 2021 •
edited
Loading

PR Summary

Add the cgmanifest file for the modules that are shipped with PowerShell.

PR Context

PR Checklist

@ghost ghost assigned anmenaga Oct 18, 2021
@adityapatwardhan adityapatwardhan added Backport-7.2.x-Consider CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Oct 18, 2021
@daxian-dbw
Copy link
Member
daxian-dbw commented Oct 18, 2021

Does this file have to be at the root directory? More and more configuration files are put at the root directory, and I wonder if any of them can be put in sub-directories.

@daxian-dbw daxian-dbw requested a review from TravisEz13 October 18, 2021 20:02
@TravisEz13
Copy link
Member
TravisEz13 commented Oct 18, 2021

This file must be in the root folder, but I don't think we need it. Can talk offline because I'm just frustrated with CG right now. 🤦🏼‍♂️

@TravisEz13 TravisEz13 marked this pull request as draft October 18, 2021 20:11
@adityapatwardhan
Copy link
Member Author
adityapatwardhan commented Oct 18, 2021

I will close this PR as this is not needed.

@adityapatwardhan adityapatwardhan marked this pull request as ready for review October 19, 2021 17:37
@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned anmenaga Oct 19, 2021
@daxian-dbw daxian-dbw merged commit a82630a into PowerShell:master Oct 19, 2021
@adityapatwardhan adityapatwardhan deleted the AddCgManifest branch October 19, 2021 21:34
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Oct 21, 2021
@adityapatwardhan @daxian-dbw
Add cgmanifest.json for generating correct third party notice file (P…
8955154 
…owerShell#16266)
@ghost
Copy link
ghost commented Oct 21, 2021

🎉v7.2.0-rc.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link
ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@adityapatwardhan @TrapGodBrim
Add cgmanifest.json for generating correct third party notice file (P…
0e5eeb7 
…owerShell#16266)
@TravisEz13 TravisEz13 mentioned this pull request May 24, 2022
Merged
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

Assignees

@daxian-dbw daxian-dbw

Labels

Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adityapatwardhan @daxian-dbw @TravisEz13 @anmenaga
0