Don't allow Move-Item with FileSystemProvider to move a directory into itself
#16198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
reviewed
Oct 5, 2021
src/System.Management.Automation/namespaces/FileSystemProvider.cs
Outdated
Show resolved
Hide resolved
rjmholt
approved these changes
Oct 5, 2021
Co-authored-by: Robert Holt <rjmholt@gmail.com>
iSazonov
reviewed
Oct 6, 2021
adityapatwardhan
approved these changes
Oct 12, 2021
daxian-dbw
pushed a commit
to daxian-dbw/PowerShell
that referenced
this pull request
Oct 21, 2021
|
🎉 Handy links: |
|
🎉 Handy links: |
TrapGodBrim
pushed a commit
to TrapGodBrim/PowerShell
that referenced
this pull request
Jan 19, 2022
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add an explicit check that the destination path is not a subdirectory of the source path.
PR Context
When
DirectoryInfo.MoveTo()is used and the destination is a subfolder of the source, an Access Denied exception is returned. However, the error code for this cannot be differentiated from other Access Denied cases like you don't have permission for the destination or across DFS volumes. So the FileSystemProvider falls back toCopyAndDelete()to handle this case. However, for this scenario, this results in infinite recursion.Since you can't move a parent into a child path, it makes sense to check for this condition and return an error. This is a regression from 7.1 due to other changes needed for FileSystemProvider to fix other
Move-itembehavior.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).