8000 Don't use `ArgumentList` when creating COM object as it's not applicable to the COM parameter set by daxian-dbw · Pull Request #15915 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Don't use ArgumentList when creating COM object as it's not applicable to the COM parameter set #15915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2021
Merged

Don't use ArgumentList when creating COM object as it's not applicable to the COM parameter set #15915

merged 1 commit into from
Aug 14, 2021

Conversation

daxian-dbw
Copy link
Member

PR Summary

We ran into a .NET bug in .NET 6 preview.7 when creating a COM object with Activator.CreateInstance. The bug is triggered when passing an empty arguments array along with the COM type to CreateInstance (see the bug here). The workaround is to not passing in the empty argument array.

When looking at our New-Object code with @adityapatwardhan, we found -ArgumentList is not even in the COM parameter set, but the COM object creation code is still using ArgumentList. That's not right and is fixed in this PR.

PR Checklist

@ghost ghost assigned TravisEz13 Aug 12, 2021
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Aug 13, 2021
@adityapatwardhan adityapatwardhan merged commit 05e6413 into PowerShell:master Aug 14, 2021
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.9 milestone Aug 14, 2021
@daxian-dbw daxian-dbw deleted the comobj branch August 14, 2021 20:58
xtqqczze pushed a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request Aug 20, 2021
@daxian-dbw @xtqqczze
Don't use ArgumentList when creating COM object as it's not applica…
6989a38 
…ble to the COM parameter set (PowerShell#15915)
@ghost
Copy link
ghost commented Aug 23, 2021

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link
ghost commented Sep 28, 2021

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

Assignees

@adityapatwardhan adityapatwardhan

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.9
Development

Successfully merging this pull request may close these issues.
5 participants
@daxian-dbw @rjmholt @adityapatwardhan @TravisEz13 @iSazonov
0