8000 Only allow `-File` to accept `.ps1` scripts on Windows by SteveL-MSFT · Pull Request #15859 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Only allow -File to accept .ps1 scripts on Windows #15859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 3, 2021
Merged

Only allow -File to accept .ps1 scripts on Windows #15859

merged 5 commits into from
Aug 3, 2021

Conversation

SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Aug 3, 2021 •
edited
Loading

PR Summary

A change was made previously to support shebang on Linux to accept files without requiring .ps1 extension. However, Windows doesn't support shebang, so we should be consistent with Windows PowerShell and only allow for scripts with .ps1 extension.

Fix is to update consolehost -File parsing path to check if the file has a .ps1 extension on Windows and return an error.
A bunch of tests had to be updated with the new behavior.

PR Checklist

@ghost ghost assigned adityapatwardhan Aug 3, 2021
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Aug 3, 2021
@SteveL-MSFT
Copy link
Member Author

static analysis failures are not related to this PR, still not sure why those URLs fail in CI but work locally from my dev machine unless CI is using a proxy for internet.

@sdwheeler sdwheeler mentioned this pull request Aug 3, 2021
Closed
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 3, 2021
@SteveL-MSFT @PaulHigin
Update src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParam…
f0bef77 
…eterParser.cs

Co-authored-by: Paul Higinbotham <paulhi@microsoft.com>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 3, 2021
@SteveL-MSFT
Copy link
Member Author
SteveL-MSFT commented Aug 3, 2021 •
edited by unfurl-links bot
Loading

Don't know why codeql is failing as it's complaining about --print-diagnostics-summary being an invalid switch, but it's clearly supported via https://codeql.github.com/docs/codeql-cli/manual/database-interpret-results/

@TravisEz13 TravisEz13 added the WG-Security security related areas such as JEA label Aug 3, 2021
@TravisEz13 TravisEz13 changed the title Only allow -File to accept .ps1 scripts on Windows Only allow -File to accept .ps1 scripts on Windows Aug 3, 2021
@TravisEz13 TravisEz13 merged commit 6933c5b into PowerShell:master Aug 3, 2021
@SteveL-MSFT SteveL-MSFT deleted the file-ps1 branch August 6, 2021 20:02
@ghost
Copy link
ghost commented Aug 23, 2021

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link
ghost commented Sep 28, 2021

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Nov 15, 2021
Closed
Merged
@anttiah anttiah mentioned this pull request Nov 17, 2021
Open
5 tasks
@daxian-dbw daxian-dbw mentioned this pull request A1FE Jan 18, 2022
Closed
@colejohnson66 colejohnson66 mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt approved these changes

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@PaulHigin PaulHigin PaulHigin approved these changes

@iSazonov iSazonov iSazonov approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@TravisEz13 TravisEz13

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log WG-Security security related areas such as JEA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SteveL-MSFT @rjmholt @TravisEz13 @PaulHigin @iSazonov @adityapatwardhan
0