8000 Fix `CA1052` in `TypeCatalogGen` by xtqqczze · Pull Request #15840 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix CA1052 in TypeCatalogGen #15840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for Gi 8000 tHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2021
Merged

Fix CA1052 in TypeCatalogGen #15840

merged 2 commits into from
Aug 5, 2021

Conversation

xtqqczze
Copy link
Contributor

In #15775, we missed a warning as TreatWarningsAsErrors was not enabled.

Again, possible breaking public API change (Unlikely Grey Area), however instantiating the class has no obvious utility and furthermore the API doesn't appear to be publicly documented.

@ghost ghost assigned TravisEz13 Jul 29, 2021
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 29, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Aug 5, 2021
@ghost
Copy link
ghost commented Aug 5, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13
Copy link
Member

This is a tool not part of PowerShell, so not a breaking change

@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 5, 2021
@TravisEz13 TravisEz13 changed the title Fix CA1052 in TypeCatalogGen Fix CA1052 in TypeCatalogGen Aug 5, 2021
@TravisEz13 TravisEz13 merged commit 44595a4 into PowerShell:master Aug 5, 2021
@TravisEz13 TravisEz13 added this to the 7.2.0-preview.9 milestone Aug 5, 2021
@xtqqczze xtqqczze deleted the CA1052-p3 branch August 6, 2021 02:27
@ghost
Copy link
ghost commented Aug 23, 2021

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link
ghost commented Sep 28, 2021

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@TravisEz13 TravisEz13

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.9
Development

Successfully merging this pull request may close these issues.
3 participants
@xtqqczze @TravisEz13 @iSazonov
0