8000 Enhance Remove-Item to work with OneDrive (Third) by iSazonov · Pull Request #15571 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Enhance Remove-Item to work with OneDrive (Third) #15571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 5, 2021
Merged

Enhance Remove-Item to work with OneDrive (Third) #15571

merged 11 commits into from
Aug 5, 2021

Conversation

iSazonov
Copy link
Collaborator
@iSazonov iSazonov commented Jun 13, 2021 •
edited
Loading

PR Summary

Fix #15466

Continue #15260

EnsureExtendedPrefix is copy-pasted from .Net Runtime repository.

PR Context

PR Checklist

@ghost ghost assigned daxian-dbw Jun 13, 2021
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jun 13, 2021
@iSazonov iSazonov assigned rjmholt and unassigned daxian-dbw Jun 13, 2021
@iSazonov iSazonov requested review from rjmholt and rkeithhill June 13, 2021 04:34
jborean93
jborean93 reviewed Jun 16, 2021
View reviewed changes
@iSazonov
Copy link
Collaborator Author

@rjmholt Friendly ping :-)

@iSazonov iSazonov mentioned this pull request Jun 22, 2021
Closed
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 25, 2021
@ghost
Copy link
ghost commented Jun 25, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

rjmholt
rjmholt reviewed Jul 26, 2021
View reviewed changes
@iSazonov iSazonov force-pushed the isreparsepointlikesymlink3 branch from 35ebe2c to b28f930 Compare July 27, 2021 06:04
@rjmholt
Copy link
Collaborator
rjmholt commented Jul 27, 2021

@iSazonov please add comments around code that's been copy/pasted from .NET about where it's come from

@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 27, 2021
@iSazonov
Copy link
Collaborator Author

@iSazonov please add comments around code that's been copy/pasted from .NET about where it's come from

There is already #region Helpers for long paths from .Net Runtime.

@ghost ghost added the Review - Needed The PR is being reviewed label Aug 4, 2021
@ghost
Copy link
ghost commented Aug 4, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@rjmholt
Copy link
Collaborator
rjmholt commented Aug 5, 2021

/azp run

@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 5, 2021
@azure-pipelines
Copy link
Azure Pipelines successfully started running 6 pipeline(s).

rjmholt
rjmholt reviewed Aug 5, 2021
View reviewed changes
SteveL-MSFT
SteveL-MSFT reviewed Aug 5, 2021
View reviewed changes
@rjmholt @SteveL-MSFT
Update src/System.Management.Automation/engine/Utils.cs
bcdab46 
Co-authored-by: Steve Lee <slee@microsoft.com>
SteveL-MSFT
SteveL-MSFT reviewed Aug 5, 2021
View reviewed changes
SteveL-MSFT
SteveL-MSFT reviewed Aug 5, 2021
View reviewed changes
SteveL-MSFT
SteveL-MSFT reviewed Aug 5, 2021
View reviewed changes
@rjmholt @SteveL-MSFT
Apply suggestions from code review
016267e 
Co-authored-by: Steve Lee <slee@microsoft.com>
@rjmholt
Copy link
Collaborator
rjmholt commented Aug 5, 2021

@PoshChan please remind me in 1 hour

@rjmholt rjmholt enabled auto-merge (squash) August 5, 2021 17:39
SteveL-MSFT
SteveL-MSFT reviewed Aug 5, 2021
View reviewed changes
rjmholt
rjmholt reviewed Aug 5, 2021
View reviewed changes
@PoshChan
Copy link
Collaborator
PoshChan commented Aug 5, 2021

@rjmholt, this is the reminder you requested 1 hour ago

@rjmholt rjmholt merged commit 45adfee into PowerShell:master Aug 5, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.9 milestone Aug 5, 2021
@iSazonov iSazonov deleted the isreparsepointlikesymlink3 branch August 5, 2021 18:46
@ghost
Copy link
ghost commented Aug 23, 2021

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 23, 2021
Closed
@iSazonov iSazonov mentioned this pull request Aug 31, 2021
Closed
@ghost
Copy link
ghost commented Sep 28, 2021

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jborean93 jborean93 jborean93 left review comments

@SteveL-MSFT SteveL-MSFT SteveL-MSFT left review comments

@rjmholt rjmholt rjmholt approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@rkeithhill rkeithhill Awaiting requested review from rkeithhill

Assignees

@rjmholt rjmholt

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.9
Development

Successfully merging this pull request may close these issues.

Remove-Item does not work correctly with long paths
6 participants
@iSazonov @rjmholt @PoshChan @jborean93 @SteveL-MSFT @daxian-dbw 31D6
0