8000 Remove unneeded SSH remoting std handle workaround by PaulHigin · Pull Request #15308 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Remove unneeded SSH remoting std handle workaround #15308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2021
Merged

Remove unneeded SSH remoting std handle workaround #15308

merged 1 commit into from
Apr 30, 2021

Conversation

PaulHigin
Copy link
Contributor

PR Summary

This PR removes an unneeded SSH remoting .NET std stream workaround. Issue #15229.

PR Context

In the early days .NET stream reader/writer did not correctly handle std streams on Windows plaforms only, and we had a PInvoke workaround. This workaround is no longer needed and can be removed. This change also disables the ability for Console APIs to write to stdout, which is reserved for PSRP messages only.

PR Checklist

@PaulHigin
Remove unneeded SSH std handle workaround
< 8000 batch-deferred-content class="d-inline-block" data-url="/PowerShell/PowerShell/commits/checks-statuses-rollups">
ff7b81f
@ghost ghost assigned daxian-dbw Apr 26, 2021
@PaulHigin PaulHigin requested review from SteveL-MSFT and iSazonov and removed request for SteveL-MSFT April 26, 2021 16:26
iSazonov
iSazonov reviewed Apr 29, 2021
View reviewed changes
Copy link
Collaborator
@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to add a test?

@PaulHigin
Copy link
Contributor Author

No new tests are needed for this.

@daxian-dbw daxian-dbw merged commit a95b2cb into PowerShell:master Apr 30, 2021
rkeithhill pushed a commit to rkeithhill/PowerShell that referenced this pull request May 3, 2021
@PaulHigin @rkeithhill
Remove unneeded SSH standard handle workaround (PowerShell#15308)
db55500
@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label May 26, 2021
@ghost
Copy link
ghost commented May 27, 2021

🎉v7.2.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@daxian-dbw daxian-dbw

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulHigin @iSazonov @daxian-dbw
0