Make sure daily release tag does not change when retrying failures #15286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
commented
Apr 20, 2021
| @@ -25,7 +34,7 @@ steps: | |||
| displayName: 'Set repo Root' | |||
|
|
|||
| - powershell: | | |||
| $createJson = ("${{ parameters.ReleaseTagVarName }}" -ne "no") | |||
| $createJson = ("${{ parameters.CreateJson }}" -ne "no") | |||
There was a problem hiding this comment.
This was a pre-existing issue I noticed when verifying the fix.
adityapatwardhan
approved these changes
Apr 21, 2021
Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
rkeithhill
pushed a commit
to rkeithhill/PowerShell
that referenced
this pull request
May 3, 2021
…owerShell#15286) Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Make sure daily release tag does not change when retrying failures
PR Context
If the seed that is used for a counter changes for a rerun, the variables are recalculated on rerun.
This PR persists the release tag as an artifact, preventing any change.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).