8000 Revert "Enhance Remove-Item to work with OneDrive (#14902)" by TravisEz13 · Pull Request #15253 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Revert "Enhance Remove-Item to work with OneDrive (#14902)" #15253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2021
Merged

Revert "Enhance Remove-Item to work with OneDrive (#14902)" #15253

merged 1 commit into from
Apr 16, 2021

Conversation

TravisEz13
Copy link
Member
@TravisEz13 TravisEz13 commented Apr 16, 2021 •
edited
Loading

PR Summary

We have been having issues with Remove-Item -Recure -Force failing since fafc38f.

So, reverting that commit until the issue has been addressed.

PR Context

https://dev.azure.com/powershell/PowerShell/_build/results?buildId=76645&view=logs&j=719313b2-5d75-51d7-9f16-928d568dcba1&t=51cacb73-0bf2-5113-ddc2-bada8ccfae1e&l=114

Tests were failing with:

 Describing About help files can be found in AllUsers scope 
 [-] Error occurred in Describe block 0ms 
 IOException: The directory is not empty. : 'C:\Users\VssAdministrator\Documents\PowerShell\Help\' 
 IOException: Cannot remove item C:\Users\VssAdministrator\Documents\PowerShell\Help\: The directory is not empty. : 'C:\Users\VssAdministrator\Documents\PowerShell\Help\' 
 at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\HelpSystem.Tests.ps1: line 267 
 at Invoke-Blocks, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 135 
 at Invoke-TestGroupSetupBlocks, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 121 
 at DescribeImpl, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\Describe.ps1: line 209

PR Checklist

@ghost ghost assigned rjmholt Apr 16, 2021
@TravisEz13

This comment has been minimized.

Sign in to view
@azure-pipelines

This comment has been minimized.

Sign in to view
@TravisEz13 TravisEz13 closed this Apr 16, 2021
@TravisEz13 TravisEz13 reopened this Apr 16, 2021
@TravisEz13
Copy link
Member Author

/azp list

@azure-pipelines
Copy link
CI/CD Pipelines for this repository:

@TravisEz13

This comment has been minimized.

Sign in to view
@azure-pipelines

This comment has been minimized.

Sign in to view
@TravisEz13

This comment has been minimized.

Sign in to view
@TravisEz13

This comment has been minimized.

Sign in to view
@azure-pipelines

This comment has been minimized.

Sign in to view
@TravisEz13

This comment has been minimized.

Sign in to view
@azure-pipelines

This comment has been minimized.

Sign in to view
@TravisEz13

This comment has been minimized.

Sign in to view
@azure-pipelines

This comment has been minimized.

Sign in to view
@TravisEz13
Copy link
Member Author

/azp run PowerShell-CI-Windows-daily

@azure-pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@TravisEz13 TravisEz13 marked this pull request as ready for review April 16, 2021 20:41
@TravisEz13 TravisEz13 merged commit 720c615 into master Apr 16, 2021
@TravisEz13 TravisEz13 deleted the daily-issue-20210416 branch April 16, 2021 20:43
@rjmholt
Copy link
Collaborator
rjmholt commented Apr 16, 2021

@iSazonov #14902 caused an issue with Remove-Item, forcing us to revert it:

  Describing About help files can be found in AllUsers scope
    [-] Error occurred in Describe block 0ms
      IOException: The directory is not empty. : 'C:\Users\VssAdministrator\Documents\PowerShell\Help\'
      IOException: Cannot remove item C:\Users\VssAdministrator\Documents\PowerShell\Help\: The directory is not empty. : 'C:\Users\VssAdministrator\Documents\PowerShell\Help\'
      at <ScriptBlock>, D:\a\1\s\test\powershell\engine\Help\HelpSystem.Tests.ps1: line 267
      at Invoke-Blocks, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 135
      at Invoke-TestGroupSetupBlocks, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\SetupTeardown.ps1: line 121
      at DescribeImpl, D:\a\1\s\src\powershell-win-core\bin\Release\net6.0\win7-x64\publish\Modules\Pester\4.10.1\Functions\Describe.ps1: line 209

JamesWTruher
JamesWTruher reviewed Apr 16, 2021
View reviewed changes
src/System.Management.Automation/engine/Utils.cs
@@ -1863,7 +1863,7 @@ internal static string GetFormatStyleString(FormatStyle formatStyle)

if (ExperimentalFeature.IsEnabled("PSAnsiRendering"))
{
PSStyle psstyle = PSStyle.Instance;
PSStyle psstyle = PSStyle.Instance;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra white space?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will remove in follow PR.

@iSazonov
Copy link
Collaborator

I wonder how was CIs passed in the PR. Should we fix anything in CIs?

@iSazonov iSazonov mentioned this pull request Apr 17, 2021
Merged
22 tasks
@TravisEz13
Copy link
Member Author

@iSazonov No the daily CI run serially. You should open a new PR and fix the issue in the remove-item code.

rkeithhill pushed a commit to rkeithhill/PowerShell that referenced this pull request May 3, 2021
@TravisEz13 @rkeithhill
Revert "Enhance Remove-Item to work with OneDrive (PowerShell#14902)" (…
806df76 
…PowerShell#15253)

This reverts commit fafc38f.
@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWTruher JamesWTruher JamesWTruher left review comments

@iSazonov iSazonov iSazonov left review comments

@rjmholt rjmholt rjmholt approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@rjmholt rjmholt

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TravisEz13 @rjmholt @iSazonov @JamesWTruher @daxian-dbw
0