8000 Move cross platform DSC code to a subsystem by anmenaga · Pull Request #15127 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Move cross platform DSC code to a subsystem #15127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 21, 2021
Merged

Move cross platform DSC code to a subsystem #15127

merged 19 commits into from
May 21, 2021

Conversation

anmenaga
Copy link

PR Summary

This work is in the context of Minimal PowerShell.
Cross platform DSC code that was in System.Management.Automation.dll is extracted as a PowerShell subsystem (this PR) and moved to a new Microsoft.PowerShell.DscSubsystem.dll to be shipped with PSDesiredStateConfiguration v3 module (PR in PSDesiredStateConfiguration repo).

PR Context

This PR is following guidelines from subsystem architecture document:

  • Cross platform DSC code is removed from System.Management.Automation.dll and placed into a new Microsoft.PowerShell.DscSubsystem.dll in PSDesiredStateConfiguration v3 module.
  • Subsystem interface ICrossPlatformDsc is defined in SMA and implemented in Microsoft.PowerShell.DscSubsystem.dll
  • Subsystem registration happens dynamically with the help of IModuleAssemblyInitializer.OnImport (implemented in Microsoft.PowerShell.DscSubsystem.dll) when PSDesiredStateConfiguration v3 module is loaded.

PR Checklist

@anmenaga anmenaga added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 30, 2021
@anmenaga anmenaga requested a review from daxian-dbw March 30, 2021 22:41
@iSazonov
Copy link
Collaborator

Cross platform DSC code is removed from System.Management.Automation.dll and placed into a new Microsoft.PowerShell.DscSubsystem.dll in PSDesiredStateConfiguration v3 module.

Why not move the old code too?

@anmenaga
Copy link
Author

@iSazonov old code is planned to be removed completely by a separate PR.

@iSazonov
Copy link
Collaborator
iSazonov commented Apr 1, 2021 •
edited
Loading

@iSazonov old code is planned to be removed completely by a separate PR.

And the experimental "PS7DscSupport" flag too? Release will contain only new code?

PSDesiredStateConfiguration v3 module (PR in PSDesiredStateConfiguration repo).

Private repo? Is a plan to make public?

@TravisEz13
Copy link
Member

Will this be backported anywhere?

@anmenaga
Copy link
Author

And the experimental "PS7DscSupport" flag too? Release will contain only new code?

The current plan is: "yes" to both questions.

Private repo? Is a plan to make public?

Yes, the plan is to make it public.

@anmenaga
Copy link
Author

Will this be backported anywhere?

Good question; At this point I don't see a strong reason for backporting, considering GC is happy as it currently is without the backport.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 20, 2021
@ghost ghost added the Stale label May 5, 2021
@ghost
Copy link
ghost commented May 5, 2021

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@adityapatwardhan
Copy link
Member

@anmenaga Please resolve merge conflicts.

@ghost ghost removed the Stale label May 5, 2021
@anmenaga anmenaga mentioned this pull request May 10, 2021
Merged
22 tasks
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 11, 2021
@adityapatwardhan
Copy link
Member

@anmenaga Please respond to comment from Dongbo: #15127 (comment)

@anmenaga
Copy link
Author

Updated according to offline discussion with Dongbo and Steve. @daxian-dbw can you please have another look? Thank you.

@adityapatwardhan adityapatwardhan merged commit 8d017d8 into PowerShell:master May 21, 2021
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.6 milestone May 21, 2021
@iSazonov
Copy link
Collaborator

@anmenaga Great work!

@ghost
Copy link
ghost commented May 27, 2021

🎉v7.2.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 left review comments

@iSazonov iSazonov iSazonov left review comments

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

Assignees

@adityapatwardhan adityapatwardhan

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.6
Development

Successfully merging this pull request may close these issues.
5 participants
@anmenaga @iSazonov @TravisEz13 @adityapatwardhan @daxian-dbw
0