8000 Update .NET to version `6.0.100-preview.2.21155.3` by adityapatwardhan · Pull Request #15007 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@adityapatwardhan
Copy link
Member
@adityapatwardhan adityapatwardhan commented Mar 12, 2021

PR Summary

Update the .NET SDK to .NET 6 preview 2.

PR Context

PR Checklist

Copy link
< 8000 span class="d-inline-flex"> @anmenaga anmenaga Mar 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look like it is related to bumping .NET version. Probably better to move this to a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to this issue i reported: dotnet/roslyn#51849

Copy link
@anmenaga anmenaga Mar 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why this System.Speech.dll is mentioned here (looks like it was added by this PR)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comes with the framework i guess

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reported to .Net Runtime repo.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curios why System.Security.Cryptography.Pkcs was on version="5.0.1" while all neighbor items were on 6.0.0-preview.1 - is this expected or something we missed previously?

Copy link
Collaborator
@iSazonov iSazonov Mar 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not all packages was updated in .Net Runtime for Preview.1. There are another packages like this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we missed updating a couple of packages for preview 1. Should not be a problem this release though.

@anmenaga anmenaga added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 12, 2021
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 12, 2021
@rjmholt rjmholt assigned rjmholt and unassigned anmenaga Mar 15, 2021
@adityapatwardhan
Copy link
Member Author

Snapstore has an outage which is cause the link tests to fail.

8000
@adityapatwardhan adityapatwardhan merged commit 5c4a80e into PowerShell:master Mar 15, 2021
@adityapatwardhan adityapatwardhan deleted the UpdateDotNet6p2 branch March 15, 2021 18:22
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.4 milestone Mar 15, 2021
@ghost
Copy link
ghost commented Mar 16, 2021

🎉v7.2.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0