8000 Move misplaced test file to tests directory by MarianoAlipi · Pull Request #14908 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Move misplaced test file to tests directory #14908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 2 commits into from
Mar 8, 2021
Merged

Move misplaced test file to tests directory #14908

iSazonov merged 2 commits into from
Mar 8, 2021

Conversation

@MarianoAlipi
Copy link
Contributor
@MarianoAlipi MarianoAlipi commented Feb 26, 2021

PR Summary

Fix #14832
Move file src/System.Management.Automation/engine/Modules/ImportProvider.Tests.ps1 to test/powershell/Modules/Microsoft.PowerShell.Core/ImportProvider.Tests.ps1

PR Context

This pull request is a simple fix to issue #14832

PR Checklist

@ghost ghost assigned TravisEz13 Feb 26, 2021
rjmholt
rjmholt previously approved these changes Feb 26, 2021
View reviewed changes
@TravisEz13
Copy link
Member
TravisEz13 commented Mar 2, 2021

Importprovider is now failing...

Describing Import PowerShell provider
    [-] Import a PowerShell provider with correct name
      Expected exactly 'ReproModule\SamplePrv::test.txt', but got $null.
      66:         $result.PSPath | Should -BeExactly "ReproModule\SamplePrv::test.txt"
      at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\ImportProvider.Tests.ps1: line 66

@TravisEz13
Copy link
Member
TravisEz13 commented Mar 2, 2021

https://dev.azure.com/powershell/PowerShell/_build/results?buildId=73987&view=logs&j=65e467a7-433b-584d-c8f4-72fcd5732f9d&t=6a14d04a-9a6d-5c41-f839-531117eeb032&l=3618

@TravisEz13 TravisEz13 dismissed rjmholt’s stale review March 2, 2021 00:35

Approved with failing tests

@MarianoAlipi
Copy link
Contributor Author
MarianoAlipi commented Mar 2, 2021

I suppose that test wasn't being run so it didn't show any errors before. The ReproModule directory it tries to import doesn't exist anywhere in the repository. So I'm thinking there are missing files or the test was only temporary and slipped into the repository. What should we do?

@rjmholt
Copy link
Collaborator
rjmholt commented Mar 2, 2021

Looks like the file was added by @iSazonov in #11813. @iSazonov what's the right way to make these tests work?

@iSazonov
Copy link
Collaborator
iSazonov commented Mar 3, 2021

Looks like the file was added by @iSazonov in #11813. @iSazonov what's the right way to make these tests work?

It's mystic how it happened :-(

We should replace:

    It "Import a PowerShell provider with correct name" {
        $result = & $pwsh -NoProfile -Command "Import-Module -Name $testModulePath; Get-Item ReproModule\SamplePrv::test.txt"
        $result.PSPath | Should -BeExactly "ReproModule\SamplePrv::test.txt"
    }

with

    It "Import a PowerShell provider with correct name" {
        $result = & $pwsh -NoProfile -Command "Import-Module -Name $testModulePath; (Get-Item ReproModule\SamplePrv::test.txt).PSPath"
        $result | Should -BeExactly "ReproModule\SamplePrv::test.txt"
    }

@iSazonov
Copy link
Collaborator
iSazonov commented Mar 8, 2021

/azp run PowerShell-CI-static-analysis

@azure-pipelines
Copy link
azure-pipelines bot commented Mar 8, 2021
Azure Pipelines successfully started running 1 pipeline(s).

@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Mar 8, 2021
@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Mar 8, 2021
@iSazonov iSazonov merged commit ae5a84e into PowerShell:master Mar 8, 2021
@iSazonov
Copy link
Collaborator
iSazonov commented Mar 8, 2021

@MarianoAlipi Thanks for your contribution!

@MarianoAlipi
Copy link
Contributor Author
MarianoAlipi commented Mar 8, 2021

Thank you everyone for your help during the whole process! :)

@ghost
Copy link
ghost commented Mar 16, 2021

🎉v7.2.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

+1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test file in the wrong place

4 participants

@MarianoAlipi @TravisEz13 @rjmholt @iSazonov
0