8000 Update script to use .NET 6 build resources by adityapatwardhan · Pull Request #14705 · PowerShell/PowerShell · GitHub 8000
[go: up one dir, main page]
Skip to content

Update script to use .NET 6 build resources #14705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rjmholt merged 7 commits into from
Feb 5, 2021
Merged

Update script to use .NET 6 build resources #14705

rjmholt merged 7 commits into from
Feb 5, 2021

Conversation

@adityapatwardhan
Copy link
Member
@adityapatwardhan adityapatwardhan commented Feb 4, 2021 •
edited
Loading

PR Summary

  • Update the script to use the .NET 6 resources fir building powershell.
  • Also consider updated packages on NuGet.org when checking for updates.
  • Remove references to .NET 5.
  • Add internalfeed url to metadata file

PR Context

PR Checklist

@ghost ghost assigned rjmholt Feb 4, 2021
rjmholt
rjmholt reviewed Feb 4, 2021
View reviewed changes
daxian-dbw
daxian-dbw reviewed Feb 4, 2021
View reviewed changes
adityapatwardhan and others added 6 commits February 4, 2021 16:31
@adityapatwardhan @daxian-dbw
Update tools/UpdateDotnetRuntime.ps1
382c4c8 
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@adityapatwardhan @daxian-dbw
Update tools/UpdateDotnetRuntime.ps1
ee6cee9 
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@adityapatwardhan @daxian-dbw
Update tools/UpdateDotnetRuntime.ps1
c9acca4 
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@adityapatwardhan @daxian-dbw
Update tools/UpdateDotnetRuntime.ps1
61fc986 
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@adityapatwardhan @daxian-dbw
Update tools/UpdateDotnetRuntime.ps1
c5afcaf 
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@adityapatwardhan
Address feedback
d5b3cd1
@adityapatwardhan
Copy link
Member Author
adityapatwardhan commented Feb 5, 2021

@daxian-dbw @rjmholt Please re-review

@rjmholt rjmholt merged commit fdc9a91 into PowerShell:master Feb 5, 2021
@rjmholt rjmholt deleted the updateDontet6 branch February 5, 2021 18:29
@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Feb 6, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Feb 6, 2021
@ghost
Copy link
ghost commented Feb 12, 2021

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+2 more reviewers

@rjmholt rjmholt rjmholt approved these changes

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt rjmholt

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

5 participants

@adityapatwardhan @daxian-dbw @rjmholt @anmenaga @iSazonov
0