8000 Enable CA1043: Use integral or string argument for indexers by xtqqczze · Pull Request #14467 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Enable CA1043: Use integral or string argument for indexers #14467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Jun 28, 2021
Merged

Enable CA1043: Use integral or string argument for indexers #14467

iSazonov merged 1 commit into from
Jun 28, 2021

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Dec 20, 2020

@ghost ghost assigned TravisEz13 Dec 20, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 22, 2020
@xtqqczze xtqqczze marked this pull request as ready for review December 24, 2020 04:13
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 31, 2020
@ghost
Copy link
ghost commented Dec 31, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze xtqqczze closed this Jun 21, 2021
@xtqqczze xtqqczze reopened this Jun 21, 2021
@xtqqczze
8000 Copy link
Contributor Author
xtqqczze commented Jun 21, 2021

rebased

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Jun 24, 2021

rebased to resolve merge conflicts

@iSazonov iSazonov merged commit 1ad1c26 into PowerShell:master Jun 28, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 28, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.8 milestone Jun 28, 2021
@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Jun 28, 2021
@xtqqczze xtqqczze deleted the CA1043 branch June 29, 2021 06:40
@ghost
Copy link
ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.8

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @TravisEz13
2A78
0