E525 Add support to `$PSStyle` for strikethrough and hyperlinks by SteveL-MSFT · Pull Request #14461 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add support to $PSStyle for strikethrough and hyperlinks #14461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 4 commits into from
Dec 19, 2020
Merged

Add support to $PSStyle for strikethrough and hyperlinks #14461

iSazonov merged 4 commits into from
Dec 19, 2020

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Dec 18, 2020 •
edited
Loading

PR Summary

Strikethrough was missed in the initial implementation. Hyperlinks are getting more broadly supported so that should be added.

Also added missing tests for FromRGB() method.

PR Context

Fix #14459
Fix #14460

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from iSazonov December 18, 2020 19:28
@ghost ghost assigned daxian-dbw Dec 18, 2020
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Dec 19, 2020
@iSazonov iSazonov merged commit bc08092 into PowerShell:master Dec 19, 2020
@iSazonov iSazonov assigned iSazonov and unassigned daxian-dbw Dec 19, 2020
@iSazonov iSazonov added this to the 7.3-Consider milestone Dec 19, 2020
@SteveL-MSFT SteveL-MSFT deleted the strikethrough-links branch December 19, 2020 15:16
@ghost
Copy link
ghost commented Feb 12, 2021

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Feb 12, 2021
Closed
Closed
@sdwheeler sdwheeler mentioned this pull request Feb 18, 2021
Closed
@sdwheeler sdwheeler mentioned this pull request May 13, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

+1 more reviewer

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.3-Consider

Development

Successfully merging this pull request may close these issues.

Support ANSI links in $PSStyle Have a $PSStyle.Strikethrough

4 participants

@SteveL-MSFT @TylerLeonhardt @iSazonov @daxian-dbw
0