8000 Enable CA2249: Consider using String.Contains instead of IndexOf by xtqqczze · Pull Request #14395 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Enable CA2249: Consider using String.Contains instead of IndexOf #14395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 4 commits into from
Jan 10, 2021
Merged

Enable CA2249: Consider using String.Contains instead of IndexOf #14395

iSazonov merged 4 commits into from
Jan 10, 2021

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Dec 11, 2020

@ghost ghost assigned TravisEz13 Dec 11, 2020
@xtqqczze xtqqczze marked this pull request as ready for review December 11, 2020 16:07
iSazonov
iSazonov reviewed Dec 12, 2020
View reviewed changes
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 12, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 21, 2020
@ghost
Copy link
ghost commented Dec 21, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Jan 10, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 10, 2021
@iSazonov iSazonov merged commit 9ea718f into PowerShell:master Jan 10, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Jan 10, 2021
@xtqqczze xtqqczze deleted the CA2249 branch January 18, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @TravisEz13
0