8000 Fix IDE0090: Simplify new expression part 7 by xtqqczze · Pull Request #14341 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix IDE0090: Simplify new expression part 7 #14341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 2 commits into from
Jan 9, 2021
Merged

Fix IDE0090: Simplify new expression part 7 #14341

iSazonov merged 2 commits into from
Jan 9, 2021

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Dec 7, 2020

@ghost ghost assigned anmenaga Dec 7, 2020
@xtqqczze xtqqczze marked this pull request as ready for review December 7, 2020 15:23
iSazonov
iSazonov reviewed Dec 9, 2020
View reviewed changes
Copy link
Collaborator
@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xtqqczze I stopped review - too many unrelated changes.

xtqqczze added a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request Dec 9, 2020
@xtqqczze
Remove useless assignment to locals
ba6abe6 
Follow-up to PowerShell#14341.
@xtqqczze xtqqczze mentioned this pull request Dec 9, 2020
Merged
@xtqqczze xtqqczze marked this pull request as draft December 9, 2020 17:05
@xtqqczze xtqqczze marked this pull request as ready for review December 12, 2020 21:50
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 13, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 20, 2020
@ghost
Copy link
ghost commented Dec 20, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Jan 9, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@iSazonov iSazonov merged commit 3c7f4b5 into PowerShell:master Jan 9, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Jan 9, 2021
@xtqqczze xtqqczze mentioned this pull request Jun 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @anmenaga
0