8000 Add DocumentationAnalyzers to build by xtqqczze · Pull Request #14336 · PowerShell/PowerShell · GitHub 8000
[go: up one dir, main page]
Skip to content

Add DocumentationAnalyzers to build #14336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 5 commits into from
Jun 25, 2021
Merged

Add DocumentationAnalyzers to build #14336

iSazonov merged 5 commits into from
Jun 25, 2021

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Dec 6, 2020 •
edited
Loading

Fix #14321.

@ghost ghost assigned TravisEz13 Dec 6, 2020
@iSazonov
Copy link
Collaborator
iSazonov commented Dec 6, 2020

My concern is that will delay build. We should think about how to exclude analyzers when they are not needed, for example, when we need to quickly recompile a project locally.

I think the analyzer is not critical for us today and we could add it as optional. Optional GitHub check?

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Dec 6, 2020

PowerShell-CI-windows (Build for Windows Windows Build) #PR-14336-20201206.01 Add DocumentationAnalyzers to build completed in 14m 10s.

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Dec 6, 2020 •
edited
Loading

My concern is that will delay build. We should think about how to exclude analyzers when they are not needed, for example, when we need to quickly recompile a project locally.

I think the analyzer is not critical for us today and we could add it as optional. Optional GitHub check?

For a fast local build: dotnet build -p:RunAnalyzers=false

@xtqqczze xtqqczze force-pushed the DocumentationAnalyzers branch from 3af7e60 to 84524f1 Compare December 7, 2020 00:28
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 14, 2020
@ghost
Copy link
ghost commented Dec 14, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze xtqqczze force-pushed the DocumentationAnalyzers branch from 84524f1 to ae6db46 Compare December 14, 2020 14:38
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Dec 21, 2020

My concern is that will delay build. We should think about how to exclude analyzers when they are not needed, for example, when we need to quickly recompile a project locally.
I think the analyzer is not critical for us today and we could add it as optional. Optional GitHub check?

For a fast local build: dotnet build -p:RunAnalyzers=false

@iSazonov Perhaps we could add -SkipAnalyzers switch parameter to Start-PSBuild?

@iSazonov
Copy link
Collaborator
iSazonov commented Dec 22, 2020

@iSazonov Perhaps we could add -SkipAnalyzers switch parameter to Start-PSBuild?

Good point.

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 22, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 29, 2020
@ghost
Copy link
ghost commented Dec 29, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze xtqqczze mentioned this pull request Jun 21, 2021
Closed
@iSazonov iSazonov requested a review from sdwheeler June 22, 2021 19:06
@xtqqczze xtqqczze closed this Jun 24, 2021
@xtqqczze xtqqczze reopened this Jun 24, 2021
@iSazonov iSazonov merged commit 078cfea into PowerShell:master Jun 25, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 25, 2021
@iSazonov iSazonov self-assigned this Jun 25, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.8 milestone Jun 25, 2021
@xtqqczze xtqqczze mentioned this pull request Jun 25, 2021
Closed
@xtqqczze xtqqczze deleted the DocumentationAnalyzers branch June 25, 2021 12:46
@rjmholt rjmholt added CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log CL-Tools Indicates that a PR should be marked as a tools change in the Change Log and removed CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log labels Jul 21, 2021
@ghost
Copy link
ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jul 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

@sdwheeler sdwheeler Awaiting requested review from sdwheeler

Assignees

@iSazonov iSazonov

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.8

Development

Successfully merging this pull request may close these issues.

Enable DocumentationAnalyzers

4 participants

@xtqqczze @iSazonov @rjmholt @TravisEz13
0