Update markdown test tools #14325

RDIL · 2020-12-04T20:26:52Z

Signed-off-by: Reece Dunham me@rdil.rocks

PR Summary

Update the external markdown testing tools to the latest version

PR Context

Staying somewhat up-to-date

PR Checklist

xtqqczze · 2020-12-05T14:13:48Z

2020-12-04T21:26:40.2433904Z       [-] https://github.com/powershell/powershell-rfc â†’ Status: 429 should work 60.18s
2020-12-04T21:26:40.2467358Z         RuntimeException: Failed to complete request to "https://github.com/powershell/powershell-rfc â†’ Status: 429". Response status code does not indicate success: 404 (Not Found).
2020-12-04T21:26:40.2469184Z         at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 119

HTTP 429 -> Too many requests

Related upstream issue: tcort/markdown-link-check#101

xtqqczze · 2020-12-05T14:21:50Z

Related upstream issue: tcort/markdown-link-check#101

~~The issue is fixed in tcort/markdown-link-check#106 but there is not yet a markdown-link-check release with these changes (see tcort/markdown-link-check#141)~~ Fixed in v3.8.4.

xtqqczze · 2020-12-05T14:36:03Z

It seems markdown-link-check is making a HTTP GET request for every URL. This is not ideal behaviour for large binaries, to say the least:

PowerShell/README.md

Lines 65 to 112 in ea3036d

    
           [lts-windows-86]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/PowerShell-7.0.3-win-x86.msi 
        
           [lts-windows-64]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/PowerShell-7.0.3-win-x64.msi 
        
           [lts-ubuntu18]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts_7.0.3-1.ubuntu.18.04_amd64.deb 
        
           [lts-ubuntu16]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts_7.0.3-1.ubuntu.16.04_amd64.deb 
        
           [lts-debian9]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts_7.0.3-1.debian.9_amd64.deb 
        
           [lts-debian10]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts_7.0.3-1.debian.10_amd64.deb 
        
           [lts-centos]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts-7.0.3-1.rhel.7.x86_64.rpm 
        
           [lts-centos8]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts-7.0.3-1.centos.8.x86_64.rpm 
        
           [lts-macos]: https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/powershell-lts-7.0.3-osx-x64.pkg 
        
           [rl-windows-64]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-x64.msi 
        
           [rl-windows-86]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-x86.msi 
        
           [rl-ubuntu20]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell_7.1.0-1.ubuntu.20.04_amd64.deb 
        
           [rl-ubuntu18]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell_7.1.0-1.ubuntu.18.04_amd64.deb 
        
           [rl-ubuntu16]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell_7.1.0-1.ubuntu.16.04_amd64.deb 
        
           [rl-debian9]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell_7.1.0-1.debian.9_amd64.deb 
        
           [rl-debian10]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell_7.1.0-1.debian.10_amd64.deb 
        
           [rl-debian11]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell_7.1.0-1.debian.11_amd64.deb 
        
           [rl-centos]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-1.rhel.7.x86_64.rpm 
        
           [rl-centos8]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-1.centos.8.x86_64.rpm 
        
           [rl-macos]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-osx-x64.pkg 
        
           [rl-winarm64]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-arm64.zip 
        
           [rl-winx86-zip]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-x86.zip 
        
           [rl-winx64-zip]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/PowerShell-7.1.0-win-x64.zip 
        
           [rl-macos-tar]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-osx-x64.tar.gz 
        
           [rl-linux-tar]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-linux-x64.tar.gz 
        
           [rl-arm32]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-linux-arm32.tar.gz 
        
           [rl-arm64]: https://github.com/PowerShell/PowerShell/releases/download/v7.1.0/powershell-7.1.0-linux-arm64.tar.gz 
        
           [rl-snap]: https://snapcraft.io/powershell 
        
           [pv-windows-64]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-x64.msi 
        
           [pv-windows-86]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-x86.msi 
        
           [pv-ubuntu20]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.ubuntu.20.04_amd64.deb 
        
           [pv-ubuntu18]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.ubuntu.18.04_amd64.deb 
        
           [pv-ubuntu16]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.ubuntu.16.04_amd64.deb 
        
           [pv-debian9]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.debian.9_amd64.deb 
        
           [pv-debian10]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.debian.10_amd64.deb 
        
           [pv-debian11]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview_7.2.0-preview.1-1.debian.11_amd64.deb 
        
           [pv-centos]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview-7.2.0_preview.1-1.rhel.7.x86_64.rpm 
        
           [pv-centos8]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-preview-7.2.0_preview.1-1.centos.8.x86_64.rpm 
        
           [pv-macos]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-osx-x64.pkg 
        
           [pv-winarm64]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-arm64.zip 
        
           [pv-winx86-zip]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-x86.zip 
        
           [pv-winx64-zip]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/PowerShell-7.2.0-preview.1-win-x64.zip 
        
           [pv-macos-tar]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-osx-x64.tar.gz 
        
           [pv-linux-tar]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-linux-x64.tar.gz 
        
           [pv-arm32]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-linux-arm32.tar.gz 
        
           [pv-arm64]: https://github.com/PowerShell/PowerShell/releases/download/v7.2.0-preview.1/powershell-7.2.0-preview.1-linux-arm64.tar.gz

xtqqczze · 2020-12-05T16:41:33Z

@RDIL Please update markdown-link-check to v3.8.4.

xtqqczze · 2020-12-05T21:22:03Z

PowerShell-CI-static-analysis still has HTTP error 429 -> Too many requests

iSazonov · 2020-12-09T04:09:53Z

PowerShell-CI-static-analysis still has HTTP error 429 -> Too many requests

We need update markdown-link-check config or commandline with

retryOn429 if this is true then retry request when response is an HTTP code 429 after the duration indicated by retry-after header.

8000

xtqqczze · 2020-12-09T09:11:36Z

Documentation should be updated as well:

PowerShell/.github/CONTRIBUTING.md

Lines 91 to 102 in bb78d4b

    
           #### Checking links in documentation 
        
           Documentation is link-checked. We make use of the 
        
           markdown-link-check command line tool, 
        
           which can be run to see if any links are dead. 
        
           To run the link-checker, follow these steps: 
        
           * install [Node.js](https://nodejs.org/en/) (v6.4.0 or up) 
        
           * install markdown-link-check by 
        
             `npm install -g markdown-link-check@3.7.2` (v3.7.2 **only**) 
        
           * run `find . \*.md -exec markdown-link-check {} \;`

RDIL · 2020-12-09T18:01:35Z

@PoshChan please rerun linux

PoshChan · 2020-12-09T18:01:59Z

@RDIL, you are not authorized to request a rebuild

RDIL · 2020-12-09T18:02:25Z

Fine, I'll do it myself.

docs/maintainers/README.md

docs/community/governance.md

test/common/markdown/markdown-link.tests.ps1

xtqqczze · 2020-12-15T20:36:26Z

PowerShell-CI-static-analysis (Markdown and Common Tests):

Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/learning-powershell/powershell-beginners-guide.md.https://www.computerperformance.co.uk/powershell/index.htm should work

Connection timed out

xtqqczze · 2020-12-15T20:38:59Z

PowerShell-CI-static-analysis (Markdown and Common Tests):

Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/learning-powershell/powershell-beginners-guide.md.https://www.computerperformance.co.uk/powershell/index.htm should work

Connection timed out

Look like a transient failure, but I've submitted #14431 to update the 301 redirect.

Computer Performance
Windows PowerShell Tutorial - Introduction Microsoft's new scripting language
Windows PowerShell Tutorial. An introducton to Microsoft's latest Windows scripting language. Learn PowerShell and master WMI. Replace VBScript and CMD with the PS command line.

RDIL · 2020-12-15T20:42:46Z

PowerShell-CI-static-analysis (Markdown and Common Tests):
Verify Markdown Links.Verify links in /home/vsts/work/1/s/docs/learning-powershell/powershell-beginners-guide.md.https://www.computerperformance.co.uk/powershell/index.htm should work
Connection timed out

Look like a transient failure, but I've submitted #14431 to update the 301 redirect.

Computer Performance**Windows PowerShell Tutorial - Introduction Microsoft's new scripting language**Windows PowerShell Tutorial. An introducton to Microsoft's latest Windows scripting language. Learn PowerShell and master WMI. Replace VBScript and CMD with the PS command line.

I'll rebase once that gets merged.

Computer Performance
Windows PowerShell Tutorial - Introduction Microsoft's new scripting language
Windows PowerShell Tutorial. An introducton to Microsoft's latest Windows scripting language. Learn PowerShell and master WMI. Replace VBScript and CMD with the PS command line.

xtqqczze · 2020-12-15T22:29:55Z

I'll rebase once that gets merged.

@RDIL No need wait for that PR, failures in PowerShell-CI-static-analysis have not persisted.

ghost · 2020-12-23T02:00:08Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Signed-off-by: Reece Dunham <me@rdil.rocks>

RDIL · 2020-12-24T16:28:46Z

Whoops, that wasn't supposed to happen - sorry for anybody that got pinged due to my rebase, it usually doesn't do that!

ghost · 2021-02-12T02:06:13Z

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

ghost assigned anmenaga Dec 4, 2020

RDIL requested review from TravisEz13 and joeyaiello as code owners December 9, 2020 17:10

iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Dec 9, 2020

RDIL closed this Dec 9, 2020

RDIL reopened this Dec 9, 2020

iSazonov reviewed Dec 9, 2020

View reviewed changes

docs/maintainers/README.md Outdated Show resolved Hide resolved

iSazonov reviewed Dec 9, 2020

View reviewed changes

docs/community/governance.md Outdated Show resolved Hide resolved

xtqqczze reviewed Dec 9, 2020

View reviewed changes

test/common/markdown/markdown-link.tests.ps1 Outdated Show resolved Hide resolved

TravisEz13 approved these changes Dec 9, 2020

View reviewed changes

RDIL closed this Dec 15, 2020

RDIL reopened this Dec 15, 2020

RDIL closed this Dec 15, 2020

RDIL reopened this Dec 15, 2020

RDIL changed the title ~~Update markdown test tools~~ [On Hold] Update markdown test tools Dec 15, 2020

ghost added the Review - Needed The PR is being reviewed label Dec 23, 2020

RDIL changed the title ~~[On Hold] Update markdown test tools~~ Update markdown test tools Dec 23, 2020

RDIL added 5 commits December 24, 2020 16:27

Update markdown test tools

eb3deb9

Signed-off-by: Reece Dunham <me@rdil.rocks>

3.8.4

3a87aa5

Update docs, retry flag

f8d7d07

Fix actual dead links

d092102

Signed-off-by: Reece Dunham <me@rdil.rocks>

Experiment with removing 429 from allowed failures

1791131

RDIL requested review from SteveL-MSFT, adityapatwardhan, anmenaga and daxian-dbw as code owners December 24, 2020 16:27

RDIL added 2 commits December 24, 2020 12:05

Update links

973748b

Update links

e35aa83

RDIL requested a review from iSazonov December 24, 2020 17:06

xtqqczze approved these changes Dec 24, 2020

View reviewed changes

Merge branch 'master' into master

45bc72e

iSazonov approved these changes Jan 12, 2021

View reviewed changes

iSazonov merged commit 4a09585 into PowerShell:master Jan 12, 2021

ghost removed the Review - Needed The PR is being reviewed label Jan 12, 2021

iSazonov assigned iSazonov and unassigned anmenaga Jan 12, 2021

iSazonov added this to the 7.2.0-preview.3 milestone Jan 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update markdown test tools #14325

Update markdown test tools #14325

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Update markdown test tools #14325

Update markdown test tools #14325

Uh oh!

Conversation

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants