8000 Enable nullable: System.Management.Automation.Language.ICustomAstVisitor2 by powercode · Pull Request #14192 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Enable nullable: System.Management.Automation.Language.ICustomAstVisitor2 #14192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 3 commits into from
Dec 11, 2020
Merged

Enable nullable: System.Management.Automation.Language.ICustomAstVisitor2 #14192

iSazonov merged 3 commits into from
Dec 11, 2020

Conversation

@powercode
Copy link
Collaborator
@powercode powercode commented Nov 20, 2020

Tracking issue: #12631.

@ghost ghost assigned anmenaga Nov 20, 2020
iSazonov
iSazonov requested changes Nov 20, 2020
View reviewed changes
Copy link
Collaborator
@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please move directives.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 20, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 20, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 20, 2020
@powercode powercode force-pushed the nullable/ICustomAstVisitor2 branch from 7b69359 to 4079480 Compare November 20, 2020 18:54
@powercode powercode force-pushed the nullable/ICustomAstVisitor2 branch from 4079480 to 19244bc Compare November 20, 2020 18:55
@ghost
Copy link
ghost commented Nov 28, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov requested a review from rjmholt December 11, 2020 05:14
@rjmholt rjmholt removed the Review - Needed The PR is being reviewed label Dec 11, 2020
@rjmholt rjmholt assigned rjmholt and unassigned anmenaga Dec 11, 2020
@rjmholt rjmholt requested a review from iSazonov December 11, 2020 05:17
@iSazonov iSazonov self-assigned this Dec 11, 2020
@iSazonov iSazonov merged commit 29131d5 into PowerShell:master Dec 11, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 11, 2020
@powercode powercode deleted the nullable/ICustomAstVisitor2 branch December 14, 2020 08:17
@ghost
8000 Copy link
ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

+1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt rjmholt

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

4 participants

@powercode @rjmholt @iSazonov @anmenaga
0