8000 Enable nullable: System.Management.Automation.Provider.IContentCmdletProvider by powercode · Pull Request #14184 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Enable nullable: System.Management.Automation.Provider.IContentCmdletProvider #14184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 2 commits into from
Dec 11, 2020
Merged

Enable nullable: System.Management.Automation.Provider.IContentCmdletProvider #14184

iSazonov merged 2 commits into from
Dec 11, 2020

Conversation

@powercode
Copy link
Collaborator
@powercode powercode commented Nov 20, 2020

Tracking issue: #12631.

@powercode powercode requested a review from anmenaga as a code owner November 20, 2020 00:09
@ghost ghost assigned iSazonov Nov 20, 2020
iSazonov
iSazonov approved these changes Nov 20, 2020
View reviewed changes
src/System.Management.Automation/namespaces/IContentProvider.cs
Comment on lines 4 to 6
#nullable enable

namespace System.Management.Automation.Provider
Copy link
Collaborator
@iSazonov iSazonov Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok to have the directive here since it is for whole file.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 20, 2020
@iSazonov iSazonov requested a review from vexx32 November 20, 2020 06:56
vexx32
vexx32 approved these changes Nov 20, 2020
View reviewed changes
Copy link
Collaborator
@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🙂

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 28, 2020
@ghost
Copy link
< 8000 /span>
ghost commented Nov 28, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator
iSazonov commented Dec 11, 2020

@rjmholt Please review.

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 11, 2020
@iSazonov iSazonov merged commit d487537 into PowerShell:master Dec 11, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 11, 2020
@powercode powercode deleted the nullable/IContentCmdletProvider branch December 14, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

+2 more reviewers

@rjmholt rjmholt rjmholt approved these changes

@vexx32 vexx32 vexx32 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

4 participants

@powercode @iSazonov @rjmholt @vexx32
0