8000 Enable nullable: System.Management.Automation.Language.IScriptExtent by powercode · Pull Request #14179 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Enable nullable: System.Management.Automation.Language.IScriptExtent #14179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 3 commits into from
Dec 11, 2020
Merged

Enable nullable: System.Management.Automation.Language.IScriptExtent #14179

iSazonov merged 3 commits into from
Dec 11, 2020

Conversation

@powercode
Copy link
Collaborator
@powercode powercode commented Nov 19, 2020

Tracking issue: #12631.

@ghost ghost assigned anmenaga Nov 19, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 28, 2020
@ghost
Copy link
ghost commented Nov 28, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov requested a review from rjmholt December 11, 2020 05:18
rjmholt
rjmholt approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator
@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only we could annotate the offsets to say "may be -1"

@iSazonov iSazonov added CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log and removed Review - Needed The PR is being reviewed labels Dec 11, 2020
@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Dec 11, 2020
@iSazonov iSazonov merged commit 76e471c into PowerShell:master Dec 11, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 11, 2020
@iSazonov
Copy link
Collaborator
iSazonov commented Dec 11, 2020

If only we could annotate the offsets to say "may be -1"

Add a comment in new PR?

@powercode powercode deleted the nullable/IScriptExtent branch December 14, 2020 08:17
@ghost
Copy link
ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

+1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

4 participants

@powercode @iSazonov @rjmholt @anmenaga
0