8000 Enable nullable: Microsoft.PowerShell.Commands.IRegistryWrapper by powercode · Pull Request #14177 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Enable nullable: Microsoft.PowerShell.Commands.IRegistryWrapper #14177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2021
Merged

Enable nullable: Microsoft.PowerShell.Commands.IRegistryWrapper #14177

merged 2 commits into from
May 20, 2021

Conversation

powercode
Copy link
Collaborator

Tracking issue: #12631.

@powercode powercode requested a review from anmenaga as a code owner November 19, 2020 23:40
@ghost ghost assigned TravisEz13 Nov 19, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 28, 2020
@ghost
Copy link
ghost commented Nov 28, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator

@powercode Please resolve merge conflicts.

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 11, 2020
@powercode powercode force-pushed the nullable/IRegistryWrapper branch from 362a583 to 0bff675 Compare December 14, 2020 09:19
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 21, 2020
@ghost
Copy link
ghost commented Dec 21, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator

/azp run

@ghost ghost removed the Review - Needed The PR is being reviewed label May 18, 2021
@azure-pipelines
Copy link
Azure Pipelines successfully started running 5 pipeline(s).

@iSazonov
Copy link
Collaborator

/azp list

@azure-pipelines
Copy link
CI/CD Pipelines for this repository:

@iSazonov iSazonov closed this May 18, 2021
@iSazonov iSazonov reopened this May 18, 2021
@iSazonov iSazonov closed this May 18, 2021
@iSazonov iSazonov reopened this May 18, 2021
rjmholt
rjmholt reviewed May 18, 2021
View reviewed changes
src/System.Management.Automation/namespaces/RegistryWrapper.cs

void SetValue(string name, object value, RegistryValueKind valueKind);
void SetValue(string? name, object value, RegistryValueKind valueKind);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean to set a null-named key in the registry?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From docs: https://docs.microsoft.com/en-us/dotnet/api/microsoft.win32.registrykey.setvalue?view=net-5.0#Microsoft_Win32_RegistryKey_SetValue_System_String_System_Object_

A registry key can have one value that is not associated with any name. When this unnamed value is displayed in the registry editor, the string "(Default)" appears instead of a name. To set this unnamed value, specify either null or the empty string ("") for name.

src/System.Management.Automation/namespaces/RegistryWrapper.cs

string[] GetValueNames();

void DeleteValue(string name);

string[] GetSubKeyNames();

IRegistryWrapper CreateSubKey(string subkey);
IRegistryWrapper? CreateSubKey(string subkey);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is null returned when create fails?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From docs: https://docs.microsoft.com/en-us/dotnet/api/microsoft.win32.registrykey.createsubkey?view=net-5.0#Microsoft_Win32_RegistryKey_CreateSubKey_System_String_

Returns
RegistryKey
The newly created subkey, or null if the operation failed. If a zero-length string is specified for subkey, the current RegistryKey object is returned.

src/System.Management.Automation/namespaces/RegistryWrapper.cs

void DeleteSubKeyTree(string subkey);

object GetValue(string name);
object? GetValue(string? name);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is null returned when the key doesn't exist?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From docs: https://docs.microsoft.com/en-us/dotnet/api/microsoft.win32.registrykey.getvalue?view=net-5.0#Microsoft_Win32_RegistryKey_GetValue_System_String_

Returns
Object
The value associated with name, or null if name is not found.

@iSazonov
Copy link
Collaborator

/azp run PowerShell-CI-Windows-daily

@azure-pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 May 20, 2021
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 20, 2021
@iSazonov iSazonov merged commit e927e94 into PowerShell:master May 20, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.6 milestone May 20, 2021
@powercode powercode deleted the nullable/IRegistryWrapper branch May 25, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmholt rjmholt rjmholt left review comments

@iSazonov iSazonov iSazonov approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@iSazonov iSazonov

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Milestone
7.2.0-preview.6
Development

Successfully merging this pull request may close these issues.
4 participants
@powercode @iSazonov @rjmholt @TravisEz13
0