8000 Enable nullable: System.Management.Automation.IRSPDriverInvoke by powercode · Pull Request #14160 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Enable nullable: System.Management.Automation.IRSPDriverInvoke #14160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 4 commits into from
Jan 9, 2021
Merged

Enable nullable: System.Management.Automation.IRSPDriverInvoke #14160

iSazonov merged 4 commits into from
Jan 9, 2021

Conversation

@powercode
Copy link
Collaborator
@powercode powercode commented Nov 19, 2020

Tracking issue: #12631.

@ghost ghost assigned iSazonov Nov 19, 2020
iSazonov
iSazonov requested changes Nov 20, 2020
View reviewed changes
src/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs
Comment on lines 40 to 42

#nullable restore

Copy link
Collaborator
@iSazonov iSazonov Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#nullable restore
#nullable restore

< 8000 /p>

src/System.Management.Automation/engine/remoting/server/ServerRunspacePoolDriver.cs Outdated
Comment on lines 27 to 29

#nullable enable

Copy link
Collaborator
@iSazonov iSazonov Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move to line 34.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 20, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 20, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 20, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 29, 2020
@ghost
Copy link
ghost commented Nov 29, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov merged commit 7bbe18e into PowerShell:master Jan 9, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.3 milestone Jan 9, 2021
@powercode powercode deleted the nullable/IRSPDriverInvoke branch January 13, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@rjmholt rjmholt Awaiting requested review from rjmholt

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

2 participants

@powercode @iSazonov
0