8000 Fix SA1642 for Microsoft.PowerShell.Commands.Utility by xtqqczze · Pull Request #14142 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix SA1642 for Microsoft.PowerShell.Commands.Utility #14142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 2 commits into from
Nov 21, 2020
Merged

Fix SA1642 for Microsoft.PowerShell.Commands.Utility #14142

iSazonov merged 2 commits into from
Nov 21, 2020

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Nov 19, 2020

Fix SA1642: Constructor summary documentation should begin with standard text for Microsoft.PowerShell.Commands.Utility.

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1642.md

@ghost ghost assigned TravisEz13 Nov 19, 2020
iSazonov
iSazonov approved these changes Nov 19, 2020
View reviewed changes
@iSazonov iSazonov self-requested a review November 19, 2020 15:16
@iSazonov
Copy link
Collaborator
iSazonov commented Nov 20, 2020

@xtqqczze Please see CI fails.

@iSazonov
Copy link
Collaborator
iSazonov commented Nov 20, 2020

@xtqqczze Up.

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Nov 20, 2020

@xtqqczze Please see CI fails.

I accidentally committed dotnet_diagnostic.SA1642.severity = warning.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 20, 2020
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Nov 20, 2020

I have removed TODO commit.

@iSazonov iSazonov merged commit ca21c7c into PowerShell:master Nov 21, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 21, 2020
@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Nov 21, 2020
@xtqqczze xtqqczze deleted the SA1642-p1 branch November 21, 2020 23:28
@ghost
Copy link
ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @TravisEz13
0