8000 Enable CA1816: Dispose methods should call SuppressFinalize by xtqqczze · Pull Request #14074 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Enable CA1816: Dispose methods should call SuppressFinalize #14074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 6 commits into from
Nov 24, 2020
Merged

Enable CA1816: Dispose methods should call SuppressFinalize #14074

iSazonov merged 6 commits into from
Nov 24, 2020

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Nov 12, 2020 •
edited
Loading

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816

Also, ensure correct dispose pattern methods are present:

  • public void Dispose()
  • protected virtual void Dispose(bool disposing)

@ghost ghost assigned rjmholt Nov 12, 2020
@xtqqczze xtqqczze marked this pull request as ready for review November 13, 2020 21:45
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 21, 2020
@ghost
Copy link
ghost commented Nov 21, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

iSazonov
iSazonov requested changes Nov 21, 2020
View reviewed changes
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Nov 21, 2020
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 21, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 21, 2020
@iSazonov iSazonov assigned iSazonov and unassigned rjmholt Nov 24, 2020
@iSazonov iSazonov merged commit 358db74 into PowerShell:master Nov 24, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 24, 2020
@xtqqczze xtqqczze deleted the CA1816 branch November 24, 2020 08:02
@ghost
Copy link
ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @rjmholt
0