8000 Remove workarounds for .NET 5 RTM builds by adityapatwardhan · Pull Request #14038 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Remove workarounds for .NET 5 RTM builds #14038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 1 commit into from
Nov 11, 2020
Merged

Remove workarounds for .NET 5 RTM builds #14038

adityapatwardhan merged 1 commit into from
Nov 11, 2020

Conversation

@adityapatwardhan
Copy link
Member
@adityapatwardhan adityapatwardhan commented Nov 11, 2020 •
edited
Loading

PR Summary

Fixes #13974

Remove workarounds added to consume .NET 5 RTM build before it was released.

PR Context

PR Checklist

@ghost ghost assigned anmenaga Nov 11, 2020
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 11, 2020
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.1 milestone Nov 11, 2020
@ghost ghost removed this from the 7.2.0-preview.1 milestone Nov 11, 2020
@ghost
Copy link
ghost commented Nov 11, 2020

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

@adityapatwardhan adityapatwardhan merged commit f4ac093 into PowerShell:master Nov 11, 2020
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.1 milestone Nov 11, 2020
@adityapatwardhan adityapatwardhan deleted the RemoveNET5Workaround branch November 11, 2020 22:53
@ghost
Copy link
ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 17, 2020
Closed
< 7C20 /div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@anmenaga anmenaga

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

Remove workaround for use pre-release of .NET 5 RTM build

3 participants

@adityapatwardhan @daxian-dbw @anmenaga
0