8000 Enable nullable: System.Management.Automation.Internal.IValidateSetValuesGenerator by xtqqczze · Pull Request #14018 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Enable nullable: System.Management.Automation.Internal.IValidateSetValuesGenerator #14018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 2 commits into from
Nov 13, 2020
Merged

Enable nullable: System.Management.Automation.Internal.IValidateSetValuesGenerator #14018

iSazonov merged 2 commits into from
Nov 13, 2020

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Nov 9, 2020

Tracking issue: #12631.

@ghost ghost assigned daxian-dbw Nov 9, 2020
xtqqczze
xtqqczze commented Nov 9, 2020
View reviewed changes
iSazonov
iSazonov reviewed Nov 9, 2020
View reviewed changes
8000
@xtqqczze xtqqczze mentioned this pull request Nov 9, 2020
Closed
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Nov 11, 2020

Added documentation comment: <returns>A non-null array of non-null strings.</returns>

@xtqqczze xtqqczze requested a review from rjmholt November 11, 2020 03:41
@iSazonov iSazonov merged commit f6caf2d into PowerShell:master Nov 13, 2020
@iSazonov
Copy link
Collaborator
iSazonov commented Nov 13, 2020

Great start! :-)

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 13, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 13, 2020
@iSazonov iSazonov assigned iSazonov and unassigned daxian-dbw Nov 13, 2020
@xtqqczze xtqqczze deleted the nullable-IValidateSetValuesGenerator branch November 13, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@rjmholt rjmholt Awaiting requested review from rjmholt

+1 more reviewer

@vexx32 vexx32 vexx32 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a 4EDC PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

5 participants

@xtqqczze @iSazonov @rjmholt @vexx32 @daxian-dbw
0