10000 Fix RCS1049: Simplify boolean comparison by xtqqczze · Pull Request #13994 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix RCS1049: Simplify boolean comparison #13994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 2 commits into from
Nov 13, 2020
Merged

Fix RCS1049: Simplify boolean comparison #13994

iSazonov merged 2 commits into from
Nov 13, 2020

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Nov 6, 2020 •
edited
Loading

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1049.md

This PR includes changes to ComInterop that have also been made in dotnet/runtime#44564.

@xtqqczze xtqqczze requested a review from daxian-dbw as a code owner November 6, 2020 03:22
@ghost ghost assigned daxian-dbw Nov 6, 2020
iSazonov
iSazonov reviewed Nov 6, 2020
View reviewed changes
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 6, 2020
@ghost ghost removed this from the 7.2.0-preview.1 milestone Nov 6, 2020
@ghost
Copy link
ghost commented Nov 6, 2020

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 6, 2020
@xtqqczze xtqqczze mentioned this pull request Nov 6, 2020
Closed
@iSazonov iSazonov requested a review from TravisEz13 November 6, 2020 17:16
@xtqqczze @iSazonov
Apply suggestions from code review
e5bd094 
Co-authored-by: Ilya <darpa@yandex.ru>
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Nov 12, 2020 •
edited
Loading

This PR makes changes to ComInterop, so a corresponding PR has been opened at dotnet/runtime#44564.

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Nov 12, 2020

dotnet/runtime#44564 is approved.

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Nov 12, 2020

dotnet/runtime#44564 is merged.

@iSazonov iSazonov self-assigned this Nov 13, 2020
@iSazonov iSazonov merged commit b521b85 into PowerShell:master Nov 13, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 13, 2020
@xtqqczze xtqqczze deleted the RCS1049 branch November 13, 2020 05:31
@ghost
Copy link
ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

Assignees

@daxian-dbw daxian-dbw

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @daxian-dbw
0