8000 Enforce code style in build by xtqqczze · Pull Request #13957 · PowerShell/PowerShell · GitHub 8000
[go: up one dir, main page]
Skip to content

Enforce code style in build #13957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 3 commits into from
Nov 1, 2020
Merged

Enforce code style in build #13957

iSazonov merged 3 commits into from
Nov 1, 2020

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Oct 31, 2020 •
edited
Loading

@ghost ghost assigned iSazonov Oct 31, 2020
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Oct 31, 2020

/home/vsts/work/1/s/src/powershell/Program.cs(505,9): error IDE0036: Modifiers are not ordered [/home/vsts/work/1/s/src/powershell-unix/powershell-unix.csproj]

@xtqqczze xtqqczze mentioned this pull request Oct 31, 2020
Merged
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 1, 2020
@iSazonov iSazonov merged commit ea4cf93 into PowerShell:master Nov 1, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Nov 1, 2020
@xtqqczze xtqqczze deleted the EnforceCodeStyleInBuild branch November 1, 2020 16:44
@xtqqczze xtqqczze mentioned this pull request Nov 1, 2020
Closed
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Nov 1, 2020

@iSazonov Could you review #13936 and #13958?

@xtqqczze xtqqczze mentioned this pull request Nov 1, 2020
Closed
@ghost
Copy link
ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @iSazonov
0