Use Emacs as DefaultEditMode on Linux / OS X #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is instead of hard-coding a call to SetDefaultWindowsBindings().
|
/cc @wimcoekaerts |
|
LGTM |
|
@andschwa - you're right, it looks like the call to Clear is no longer needed. |
11 tasks
|
ah ok I did try again with Emacs mode and it worked. not sure why it didn't the first time but it worked this time so all good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1085, there was confusing over keybindings on Linux / OS X. Since we use PSReadLine, it is up to the user to choose a preferred editing mode, and PSReadLine reasonably defaulted to Windows. However, this leads to a subpar experience on non-Windows platforms, where almost everything respects Emacs keybindings (especially shells).
This fixes PSReadLine so that the key bindings are set based on the default edit mode, and sets the default edit mode to Emacs when
LINUXis defined. Pester tests are included.I do, however, have an open question for @lzybkr about the need to
_chordDispatchTable.Clear()when changing key bindings. Each ofSetDefaultWindowsBindings(),SetDefaultEmacsBindings()andSetDefaultVimBindings()bind_chordDispatchTableto a new dictionary, thus overwriting it. Is it actually necessary then to clear the previous value?