8000 Make `dispose` in `TranscriptionOption` idempotent by krishnayalavarthi · Pull Request #13839 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Make dispose in TranscriptionOption idempotent #13839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 4 commits into from
Oct 23, 2020
Merged

Make dispose in TranscriptionOption idempotent #13839

TravisEz13 merged 4 commits into from
Oct 23, 2020

Conversation

@krishnayalavarthi
Copy link
Contributor
@krishnayalavarthi krishnayalavarthi commented Oct 22, 2020 •
edited by TravisEz13
Loading

PR Summary

TranscriptionOption.Dispose() should be idempotent #13830

PR Context

TranscriptionOption.Dispose() should be idempotent #13830

PR Checklist

@ghost ghost assigned TravisEz13 Oct 22, 2020
@PaulHigin PaulHigin self-requested a review October 22, 2020 23:27
PaulHigin
PaulHigin approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor
@PaulHigin PaulHigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13
Copy link
Member
TravisEz13 commented Oct 23, 2020

@PoshChan Please remind me in 1 hour

@TravisEz13 TravisEz13 changed the title Transcription issue Make dispose in TranscriptionOption idempotent Oct 23, 2020
@TravisEz13 TravisEz13 merged commit c8feddb into PowerShell:master Oct 23, 2020
@PoshChan
Copy link
Collaborator
PoshChan commented Oct 23, 2020

@TravisEz13, this is the reminder you requested 1 hour ago

@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 16, 2020
@ghost
Copy link
ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

+1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@krishnayalavarthi @TravisEz13 @PoshChan @PaulHigin @daxian-dbw
0