8000 Fix RCS1098: Constant values should be on right side of comparisons by xtqqczze · Pull Request #13833 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix RCS1098: Constant values should be on right side of comparisons #13833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 2 commits into from
Nov 5, 2020
Merged

Fix RCS1098: Constant values should be on right side of comparisons #13833

iSazonov merged 2 commits into from
Nov 5, 2020

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Oct 22, 2020 •
edited
Loading

PR Summary

Avoid so-called Yoda conditions.

PR Context

PR Checklist

@ghost ghost assigned daxian-dbw Oct 22, 2020
@iSazonov iSazonov self-requested a review October 22, 2020 17:4 8000 4
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 22, 2020
@xtqqczze xtqqczze changed the title WIP: Fix RCS1098: Constant values should be on right side of comparisons Fix RCS1098: Constant values should be on right side of comparisons Oct 22, 2020
@xtqqczze xtqqczze mentioned this pull request Oct 22, 2020
Merged
9 tasks
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Oct 25, 2020
@xtqqczze xtqqczze marked this pull request as ready for review October 28, 2020 00:34
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 4, 2020
@ghost
Copy link
ghost commented Nov 4, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov assigned iSazonov and unassigned daxian-dbw Nov 5, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
@iSazonov iSazonov merged commit 03a0ef2 into PowerShell:master Nov 5, 2020
@xtqqczze xtqqczze deleted the RCS1098 branch November 5, 2020 16:27
@ghost
Copy link
ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze xtqqczze mentioned this pull request Nov 18, 2020
Merged
xtqqczze added a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request Nov 18, 2020
@xtqqczze
Enable SA1131: Use readable conditions
0960dc1 
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1131.md

Follow-up PowerShell#13833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @daxian-dbw
0