8000 Fixing formatting in Reset-PWSHSystemPath.ps1 by dgoldman-msft · Pull Request #13689 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fixing formatting in Reset-PWSHSystemPath.ps1 #13689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Nov 25, 2020
Merged

Fixing formatting in Reset-PWSHSystemPath.ps1 #13689

iSazonov merged 1 commit into from
Nov 25, 2020

Conversation

@dgoldman-msft
Copy link
Contributor
@dgoldman-msft dgoldman-msft commented Sep 24, 2020

Fixed examples

During a code review I found a formatting issue with two examples

Opened a PR to have formatting issues fixed

PR Checklist

@dgoldman-msft
Fixing Formatting
4d5925a 
Fixed examples
@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Sep 29, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 6, 2020
@ghost
Copy link
ghost commented Oct 6, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan
Copy link
Member
adityapatwardhan commented Oct 13, 2020

Re-running failing CI.

@ghost ghost removed the Review - Needed The PR is being reviewed label Oct 13, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 21, 2020
@ghost
Copy link
ghost commented Oct 21, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan
Copy link
Member
adityapatwardhan commented Nov 4, 2020

Re-running tests again.

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 4, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 12, 2020
@ghost
Copy link
ghost commented Nov 12, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov closed this Nov 25, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 25, 2020
@iSazonov iSazonov reopened this Nov 25, 2020
@iSazonov iSazonov merged commit bb4a0f4 into PowerShell:master Nov 25, 2020
@iSazonov
Copy link
Collaborator
iSazonov commented Nov 25, 2020

@dgoldman-msft Thanks for your contribution!

@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 25, 2020
@iSazonov iSazonov changed the title Fixing Formatting in Reset-PWSHSystemPath.ps1 Fixing formatting in Reset-PWSHSystemPath.ps1 Nov 25, 2020
@ghost
Copy link
ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@iSazonov iSazonov iSazonov approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees

@iSazonov iSazonov

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

3 participants

@dgoldman-msft @adityapatwardhan @iSazonov
0