8000 Add `-SkipLimitCheck` switch to `Import-PowerShellDataFile` by SteveL-MSFT · Pull Request #13672 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add -SkipLimitCheck switch to Import-PowerShellDataFile #13672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rjmholt merged 6 commits into from
Dec 9, 2020
Merged

Add -SkipLimitCheck switch to Import-PowerShellDataFile #13672

rjmholt merged 6 commits into from
Dec 9, 2020

Conversation

@SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Sep 22, 2020 •
edited
Loading

PR Summary

By default, there is a limit to the number of keys in a hashtable allowed to be converted from a psd1 file (500 keys). This limit is hitting user cases like DSC configuration. Change is to add a -SkipLimitCheck switch to by-pass the validation step for a hashtable.

PR Context

Fix #7979

PR Checklist

@TylerLeonhardt
Copy link
Member
TylerLeonhardt commented Sep 22, 2020

Shouldn't this follow the JSON cmdlet's -De 8000 pth so it's consistant?

@vexx32
Copy link
Collaborator
vexx32 commented Sep 22, 2020

-Depth is a bit of a different concept than just maximum number of keys/properties.

But I do think following a similar pattern is probably a better call than a switch; if a user knows the ballpark value to use, let them specify 1000 or 2000 so they can keep some control over the input file and verify things aren't getting input over and above what they expected. Have it default to 500 and then if you really want no limit, set it to zero or something?

@rjmholt
Copy link
Collaborator
rjmholt commented Sep 22, 2020

if you really want no limit, set it to zero or something?

0 or -1 both seem logical to me

@SteveL-MSFT SteveL-MSFT changed the title Add -NoLimit switch to Import-PowerShellDataFile Add -SkipLimitCheck switch to Import-PowerShellDataFile Sep 23, 2020
@SteveL-MSFT
Copy link
Member Author
SteveL-MSFT commented Sep 23, 2020

I think 0 or -1 to mean infinite only makes sense to a developer. Most users don't think like that. Per @PowerShell/powershell-committee updated to -SkipLimitCheck

rjmholt
rjmholt approved these changes Sep 24, 2020
View reviewed changes
Copy link
Collaborator
@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests LGTM. Small suggestion on the param name

@SteveL-MSFT
Copy link
Member Author
SteveL-MSFT commented Sep 25, 2020

The static analysis credscan issue is fixed as part of #13692

@ghost ghost added the Review - Needed The PR is being reviewed label Oct 6, 2020
@ghost
Copy link
ghost commented Oct 6, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

adityapatwardhan
adityapatwardhan previously requested changes Nov 4, 2020
View reviewed changes
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed labels Nov 4, 2020
@adityapatwardhan
Copy link
Member
adityapatwardhan commented Nov 13, 2020

@SteveL-MSFT Please update the PR.

@ghost ghost added the Stale label Nov 28, 2020
@ghost
Copy link
ghost commented Nov 28, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@rjmholt @adityapatwardhan
Update src/Modules/Unix/Microsoft.PowerShell.Utility/Microsoft.PowerS…
fbdd823 
…hell.Utility.psd1

Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
rjmholt
rjmholt approved these changes Dec 8, 2020
View reviewed changes
Copy link
Collaborator
@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @adityapatwardhan's suggestion applied

@ghost ghost removed the Stale label Dec 8, 2020
@rjmholt rjmholt assigned rjmholt and unassigned adityapatwardhan Dec 8, 2020
@rjmholt
Copy link
Collaborator
rjmholt commented Dec 8, 2020

@PoshChan please remind me in 18 hours

@PoshChan
Copy link
Collaborator
PoshChan commented Dec 9, 2020

@rjmholt, this is the reminder you requested 18 hours ago

@rjmholt rjmholt dismissed adityapatwardhan’s stale review December 9, 2020 19:06

Requested changes have been made

@rjmholt rjmholt merged commit 95ce064 into PowerShell:master Dec 9, 2020
@rjmholt rjmholt added CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 9, 2020
@ghost
Copy link
ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Dec 15, 2020
Closed
@sdwheeler sdwheeler mentioned this pull request Jan 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@TylerLeonhardt TylerLeonhardt Awaiting requested review from TylerLeonhardt

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt rjmholt

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Import-PowerShellDataFile Errors on files over 3230 lines

6 participants

@SteveL-MSFT @TylerLeonhardt @vexx32 @rjmholt @adityapatwardhan @PoshChan
0