8000 Change stage dependency for docker release stage in release pipeline by adityapatwardhan · Pull Request #13512 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Change stage dependency for docker release stage in release pipeline #13512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rjmholt merged 1 commit into from
Aug 29, 2020
Merged

Change stage dependency for docker release stage in release pipeline #13512

rjmholt merged 1 commit into from
Aug 29, 2020

Conversation

@adityapatwardhan
Copy link
Member
@adityapatwardhan adityapatwardhan commented Aug 24, 2020 •
edited
Loading

PR Summary

The stage dependency was incorrect and now changed it to depend on the making a GitHub release.

PR Context

PR Checklist

@ghost ghost assigned rjmholt Aug 24, 2020
@rjmholt rjmholt added the Review - Needed The PR is being reviewed label Aug 24, 2020
@adityapatwardhan
Copy link
Member Author
adityapatwardhan commented Aug 28, 2020

@rjmholt Ready to merge?

@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 28, 2020
@rjmholt
Copy link
Collaborator
rjmholt commented Aug 29, 2020

@adityapatwardhan CI doesn't seem to have run at all -- is this expected?

@adityapatwardhan
Copy link
Member Author
adityapatwardhan commented Aug 29, 2020

This is a yml only change for the release pipeline. Hence the CI does not run.

@rjmh 8000 olt rjmholt merged commit 3543491 into PowerShell:master Aug 29, 2020
@rjmholt rjmholt deleted the UpdateReleasePipeline branch August 29, 2020 19:28
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 8, 2020
@daxian-dbw daxian-dbw added this to the 7.1.0-preview.7 milestone Sep 8, 2020
@ghost
Copy link
ghost commented Sep 8, 2020

🎉v7.1.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 11, 2021
@adityapatwardhan
Change stage dependency for docker release stage in release pipeline (P…
13a9a0d 
…owerShell#13512)
@ghost
Copy link
ghost commented Mar 11, 2021

🎉v7.0.6 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt rjmholt

Labels

Backport-7.0.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.7

Development

Successfully merging this pull request may close these issues.

3 participants

@adityapatwardhan @rjmholt @daxian-dbw
0