8000 Use span-based string.Concat instead of string.Substring by xtqqczze · Pull Request #13500 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Use span-based string.Concat instead of string.Substring #13500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Oct 28, 2020
Merged

Use span-based string.Concat instead of string.Substring #13500

iSazonov merged 1 commit into from
Oct 28, 2020

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Aug 21, 2020 •
edited
Loading

PR Summary

Avoid some string allocations by using string.Concat(ReadOnlySpan, …) overloads.

Before:

str1 + str2.Substring(...) + str3

After:

string.Concat(str1, str2.AsSpan(...), str3)

PR Context

PR Checklist

@xtqqczze
Use span-based string.Concat inatead of string.Substring
cf7da7e 
Before:

```csharp
str1 + str2.Substring(...) + str3
```

After:
```csharp
string.Concat(str1, str2.AsSpan(...), str3)
```
@ghost ghost assigned anmenaga Aug 21, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Sep 5, 2020
@ghost
Copy link
ghost commented Sep 5, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Sep 5, 2020

@adityapatwardhan, @daxian-dbw Can you please review?

@xtqqczze xtqqczze changed the title Use span-based string.Concat inatead of string.Substring Use span-based string.Concat instead of string.Substring Oct 28, 2020
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Oct 28, 2020

@iSazonov Could you please review?

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 28, 2020
@iSazonov iSazonov self-assigned this Oct 28, 2020
8000
@ghost ghost removed the Review - Needed The PR is being reviewed label Oct 28, 2020
@iSazonov iSazonov merged commit 69ded77 into PowerShell:master Oct 28, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Oct 28, 2020
@xtqqczze xtqqczze deleted the span-string-concat branch October 28, 2020 10:16
@ghost
Copy link
ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze xtqqczze mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@anmenaga anmenaga

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @anmenaga
0