8000 Release pipeline fixes by adityapatwardhan · Pull Request #13473 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@adityapatwardhan
Copy link
Member
@adityapatwardhan adityapatwardhan commented Aug 18, 2020

PR Summary

Multiple fixes for the release pipeline to ix deployment of pwsh.deps.json stage and nuget release stage.

PR Context

Fixes were done in release branch. Bringing them over to master.

PR Checklist

Fix paths for nuget package release
Fix typo in package name for pwsh.deps.json upload task
Fix blobprefix and nuget package path
#Exclude all global tool packages. Their names start with 'PowerShell.'
Copy-Item "$ENV:PIPELINE_WORKSPACE/releasePipeline/finalResults/*.nupkg" -Destination "$(Pipeline.Workspace)/release" -Exclude "PowerShell.*.nupkg" -Force
$null = New-Item -ItemType Directory -Path "$(Pipeline.Workspace)/release"
Copy-Item "$ENV:PIPELINE_WORKSPACE/releasePipeline/finalResults/*.nupkg" -Destination "$(Pipeline.Workspace)/release" -Exclude "PowerShell.*.nupkg" -Force -Verbose
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing our inclusion of -Verbose here, makes me think it would be really nice if we just had a variable we could set to make the whole build spit out verbose PowerShell output. But it does also make sense as a default

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting all verbose can be too much sometimes. Specially with import-module etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its more for logging what gets copied to where.

@adityapatwardhan adityapatwardhan changed the title Release pipeline fixes WIP: Release pipeline fixes Aug 18, 2020
@adityapatwardhan adityapatwardhan changed the title WIP: Release pipeline fixes Release pipeline fixes Aug 18, 2020
@adityapatwardhan
Copy link
Member Author

@daxian-dbw I believe this is ready to merge. Other CIs will not run as this is a yml only change.

@daxian-dbw
Copy link
Member

@PoshChan Please remind me in 1 hour

@PoshChan
Copy link
Collaborator

@daxian-dbw, this is the reminder you requested 1 hour ago

@daxian-dbw daxian-dbw merged commit 1e940f5 into PowerShell:master Aug 18, 2020
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 8, 2020
@daxian-dbw daxian-dbw added this to the 7.1.0-preview.7 milestone Sep 8, 2020
@ghost
Copy link
ghost commented Sep 8, 2020

🎉v7.1.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 11, 2021
@ghost
Copy link
ghost commented Mar 11, 2021

🎉v7.0.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.0.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0