-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Release pipeline fixes #13473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release pipeline fixes #13473
Conversation
Fix paths for nuget package release
Fix typo in package name for pwsh.deps.json upload task
Fix blobprefix and nuget package path
| #Exclude all global tool packages. Their names start with 'PowerShell.' | ||
| Copy-Item "$ENV:PIPELINE_WORKSPACE/releasePipeline/finalResults/*.nupkg" -Destination "$(Pipeline.Workspace)/release" -Exclude "PowerShell.*.nupkg" -Force | ||
| $null = New-Item -ItemType Directory -Path "$(Pipeline.Workspace)/release" | ||
| Copy-Item "$ENV:PIPELINE_WORKSPACE/releasePipeline/finalResults/*.nupkg" -Destination "$(Pipeline.Workspace)/release" -Exclude "PowerShell.*.nupkg" -Force -Verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing our inclusion of -Verbose here, makes me think it would be really nice if we just had a variable we could set to make the whole build spit out verbose PowerShell output. But it does also make sense as a default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting all verbose can be too much sometimes. Specially with import-module etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its more for logging what gets copied to where.
|
@daxian-dbw I believe this is ready to merge. Other CIs will not run as this is a yml only change. |
|
@PoshChan Please remind me in 1 hour |
|
@daxian-dbw, this is the reminder you requested 1 hour ago |
|
🎉 Handy links: |
|
🎉 Handy links: |
PR Summary
Multiple fixes for the release pipeline to ix deployment of pwsh.deps.json stage and nuget release stage.
PR Context
Fixes were done in release branch. Bringing them over to master.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.