8000 Use `is not` syntax part 2 by xtqqczze · Pull Request #13338 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Use is not syntax part 2 #13338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 6 commits into from
Nov 5, 2020
Merged

Use is not syntax part 2 #13338

iSazonov merged 6 commits into from
Nov 5, 2020

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Aug 2, 2020 •
edited
Loading

PR Summary

  • More !(foo is T) -> foo is not T
  • Convert boolean logic to DNF form

PR Context

Follow-up #13323

PR Checklist

@ghost ghost assigned anmenaga Aug 2, 2020
@xtqqczze xtqqczze mentioned this pull request Aug 2, 2020
Closed
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 3, 2020
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
vexx32
vexx32 reviewed Aug 3, 2020
View reviewed changes
daxian-dbw
daxian-dbw approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member
@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Mark it for maintainers to review.

@daxian-dbw daxian-dbw added the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Aug 5, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Aug 19, 2020
@ghost
Copy link
ghost commented Aug 19, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Aug 29, 2020

@anmenaga Can you please review?

@anmenaga
Copy link
anmenaga commented Sep 1, 2020

@xtqqczze Yup; it was marked for Review - Maintainer; we'll take a look at it.

@ghost ghost added the Stale label Sep 20, 2020
@ghost
Copy link
ghost commented Sep 20, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Sep 30, 2020
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Oct 13, 2020

@iSazonov Please reopen.

@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Oct 13, 2020
@iSazonov iSazonov reopened this Oct 13, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.1 milestone Oct 13, 2020
@iSazonov
Copy link
Collaborator
iSazonov commented Oct 13, 2020

@anmenaga @daxian-dbw Can we merge to 7.2 Preview1?

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 16, 2020
xtqqczze and others added 6 commits October 23, 2020 15:45
@xtqqczze
pass 1
a66324b 
-replace '!\(([^&|]+?) is ([^&|]+?)\)', '$1 is not $2'
@xtqqczze
pass 2
f0d1a34
@xtqqczze
Convert boolean logic to DNF form
df5bd65
@xtqqczze
reformat
d2a6f0b
@xtqqczze @vexx32
Apply suggestions from code review
67ff34d 
Co-authored-by: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>
@xtqqczze
Reformat binary expressions
c5e93b6
@xtqqczze xtqqczze marked this pull request as ready for review October 23, 2020 14:46
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 23, 2020
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Oct 23, 2020

rebased

@xtqqczze xtqqczze mentioned this pull request Oct 26, 2020
Closed
14 tasks
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 31, 2020
@ghost
Copy link
ghost commented Oct 31, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Nov 5, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
@iSazonov iSazonov merged commit 03a58c4 into PowerShell:master Nov 5, 2020
@xtqqczze xtqqczze deleted the isnot2 branch November 5, 2020 16:18
@ghost
Copy link
ghost commented Nov 17, 2020

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

+1 more reviewer

@vexx32 vexx32 vexx32 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.1

Development

Successfully merging this pull request may close these issues.

5 participants

@xtqqczze @anmenaga @daxian-dbw @iSazonov @vexx32
0