8000 Mark local variable as const by xtqqczze · Pull Request #13217 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Mark local variable as const #13217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 13 commits into from
Nov 24, 2020
Merged

Mark local variable as const #13217

iSazonov merged 13 commits into from
Nov 24, 2020

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Jul 20, 2020 •
edited
Loading

PR Summary

PR Context

PR Checklist

@ghost ghost assigned rjmholt Jul 20, 2020
@rjmholt rjmholt requested review from SteveL-MSFT, daxian-dbw and iSazonov and removed request for iSazonov July 20, 2020 19:04
iSazonov
iSazonov reviewed Jul 21, 2020
View reviewed changes
This was referenced Jul 23, 2020
Closed
Closed
@xtqqczze xtqqczze force-pushed the RCS1118 branch 2 times, most recently from 7c0dc96 to 3bc6352 Compare July 23, 2020 12:42
iSazonov
iSazonov approved these changes Jul 23, 2020
View reviewed changes
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 23, 2020
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Jul 25, 2020 •
edited
Loading

@iSazonov It seems analyzers do not find code fixes inside an #if directive (unless the expression is true at compile time). This means code fixes inside #if UNIX etc have been missed from previous PRs. (Roslynator issue)
< 8000 div class="pr-review-reactions ">

@xtqqczze xtqqczze marked this pull request as ready for review July 25, 2020 17:35
@rjmholt
Copy link
Collaborator
rjmholt commented Jul 26, 2020

I'll give some extra time for other reviewers. They're likely to be out next week, so we may have to wait a little whlie

@iSazonov
Copy link
Collaborator
iSazonov commented Jul 27, 2020

It seems analyzers do not find code fixes inside an #if directive

@xtqqczze It is expected - the analyzers work at compile. You could target an Unix while run analyzers. But it is not critical.

@rjmholt
Copy link
Collaborator
8000 rjmholt commented Jul 27, 2020

@PoshChan please remind me in 10 days

@rjmholt rjmholt added the Review - Needed The PR is being reviewed label Jul 28, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 30, 2020
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Aug 3, 2020

rebased to resolve #13316 conflict

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 3, 2020
@ghost
Copy link
ghost commented Oct 18, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost added the Stale label Oct 18, 2020
@iSazonov iSazonov marked this pull request as ready for review October 19, 2020 04:18
@iSazonov
Copy link
Collaborator
iSazonov commented Oct 19, 2020

@rjmholt @SteveL-MSFT I think we can merge.

@ghost ghost removed the Stale label Oct 19, 2020
@ghost ghost added the Stale label Nov 3, 2020
@ghost
Copy link
ghost commented Nov 3, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@xtqqczze
Copy link
Contributor Author
xtqqczze commented Nov 3, 2020

This PR is ready for final review.

@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Nov 3, 2020
@iSazonov
Copy link
Collaborator
iSazonov commented Nov 5, 2020

@xtqqczze Please resolve merge conflicts.

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 12, 2020
@ghost
Copy link
ghost commented Nov 12, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze xtqqczze marked this pull request as draft November 13, 2020 01:04
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 16, 2020
@iSazonov
Copy link
Collaborator
iSazonov commented Nov 18, 2020

@xtqqczze Is it still Draft?

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 18, 2020
@xtqqczze xtqqczze marked this pull request as ready for review November 18, 2020 08:41
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 18, 2020
@iSazonov
Copy link
Collaborator
iSazonov commented Nov 21, 2020

@xtqqczze Please resolve merge conflicts.

1 similar comment
@iSazonov
Copy link
Collaborator
iSazonov commented Nov 24, 2020

@xtqqczze Please resolve merge conflicts.

@iSazonov iSazonov merged commit c7bdb24 into PowerShell:master Nov 24, 2020
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 24, 2020
@xtqqczze xtqqczze deleted the RCS1118 branch November 24, 2020 16:30
@ghost
Copy link
ghost commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

+1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt rjmholt

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

4 participants

@xtqqczze @rjmholt @iSazonov @daxian-dbw
0