8000 Code performance fixes by xtqqczze · Pull Request #12956 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Code performance fixes #12956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 4 commits into from
Jun 25, 2020
Merged

Code performance fixes #12956

iSazonov merged 4 commits into from
Jun 25, 2020

Conversation

@xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Jun 13, 2020 •
edited
Loading

PR Summary

  • Autofix RCS1080: Use 'Count/Length' property instead of 'Any' method
  • Autofix RCS1077: Optimize LINQ method call
  • Autofix RCS1235: Optimize method call

PR Context

PR Checklist

@ghost ghost assigned iSazonov Jun 13, 2020
@xtqqczze xtqqczze changed the title Rcs perf Code performance fixes Jun 15, 2020
@iSazonov
Copy link
Collaborator
iSazonov commented Jun 17, 2020

@xtqqczze Please rebase to pass CIs.

@iSazonov
Copy link
Collaborator
iSazonov commented Jun 19, 2020

@xtqqczze Please rebase.

@xtqqczze xtqqczze marked this pull request as ready for review June 19, 2020 18:30
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Jun 19, 2020

@iSazonov rebased and fixed codefactor issues

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 22, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.4 milestone Jun 22, 2020
@iSazonov iSazonov merged commit bd90f19 into PowerShell:master Jun 25, 2020
@xtqqczze xtqqczze deleted the RCS-perf branch June 29, 2020 13:08
@ghost
Copy link
ghost commented Jul 6, 2020

🎉v7.1.0-preview.5 has been released which incorporates this pull request.:tada:

Handy links:

@iSazonov iSazonov mentioned this pull request Nov 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 is a code owner

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.4

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @iSazonov
0