8000 Fix inconsistent exception message in -replace operator by jackdcasey · Pull Request #12388 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix inconsistent exception message in -replace operator #12388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 2 commits into from
Apr 28, 2020
Merged

Fix inconsistent exception message in -replace operator #12388

adityapatwardhan merged 2 commits into from
Apr 28, 2020

Conversation

@jackdcasey
Copy link
Contributor
@jackdcasey jackdcasey commented Apr 20, 2020 •
edited
Loading

PR Summary

Fix inconsistent exception message in -replace operator

PR Context

The exception message returned when passing three or more values to -replace, -ireplace or -creplace is not consistent with the actual operator used:

PS> "foo" -replace "f", "j", "h"
InvalidOperation: The -ireplace operator allows only two elements to follow it, not 3.

PS> "foo" -ireplace "f", "j", "h"
InvalidOperation: The -ireplace operator allows only two elements to follow it, not 3.

PS> "foo" -creplace "f", "j", "h"
InvalidOperation: The -replace operator allows only two elements to follow it, not 3.

My proposed changes would change the exception messages to:

PS> "foo" -replace "f", "j", "h"
InvalidOperation: The -ireplace/-replace operator allows only two elements to follow it, not 3.

PS> "foo" -ireplace "f", "j", "h"
InvalidOperation: The -ireplace/-replace operator allows only two elements to follow it, not 3.

PS> "foo" -creplace "f", "j", "h"
InvalidOperation: The -creplace operator allows only two elements to follow it, not 3.

Due to the way these parameters are passed as a boolean, we don't have visibility into exactly what parameter was used. For this reason -ireplace and -replace "share" the same error message.

Closes #12333

PR Checklist

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Apr 21, 2020
@iSazonov iSazonov added this to the 7.0.x-Servicing-Consider milestone Apr 21, 2020
IISResetMe
IISResetMe suggested changes Apr 26, 2020
View reviewed changes
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Apr 26, 2020
@jackdcasey jackdcasey requested a review from iSazonov April 26, 2020 22:01
@adityapatwardhan adityapatwardhan merged commit 767899d into PowerShell:master Apr 28, 2020
@iSazonov
Copy link
Collaborator
iSazonov 8000 commented Apr 28, 2020

@jackdcasey Thanks for your contribution!

@jackdcasey jackdcasey deleted the ReplaceOperator_VerboseExceptionMessage branch April 28, 2020 17:58
@ghost
Copy link
ghost commented May 19, 2020

🎉v7.1.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request May 19, 2020
Closed
@TravisEz13
Copy link
Member
TravisEz13 commented Jun 4, 2020

I don't think this meets the bar to backport

@TravisEz13 TravisEz13 removed this from the 7.0.x-Servicing-Consider milestone Jun 8, 2020
@TravisEz13
Copy link
Member
TravisEz13 commented Jun 8, 2020

Triage determined this does not meet the bar for backport

@iSazonov
Copy link
Collaborator
iSazonov commented Jun 9, 2020

Should we set 7.1.0-preview.3 for history?

@TravisEz13 TravisEz13 added this to the 7.1.0-preview.3 milestone Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@iSazonov iSazonov iSazonov approved these changes

+1 more reviewer

@IISResetMe IISResetMe IISResetMe requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.3

Development

Successfully merging this pull request may close these issues.

Replace Operator InvalidOperation Exception Message

5 participants

@jackdcasey @iSazonov @TravisEz13 @IISResetMe @adityapatwardhan
0