-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Scripts to update to .NET prerelease version #12284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adityapatwardhan Can you please update the PR description to include some information about what the script does and the context of why we need it?
| @@ -0,0 +1,130 @@ | |||
| [CmdletBinding()] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this file should be put in tools folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.. I can move it.
|
@daxian-dbw Ping.. |
| $stringToReplace = "<PackageReference Include=`"$($v.Name)`" Version=`"$($v.Version)`" />" | ||
| $newString = "<PackageReference Include=`"$($v.Name)`" Version=`"$($v.NewVersion)`" />" | ||
|
|
||
| $fileContent = $fileContent -replace $stringToReplace, $newString |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is doing a regex replace... maybe it's safer to using .replace()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regex replace is turning out to be a bit complicated. Keeping it as is. The intention is to create a PR after the script does the changes. So there will be a code review as a safety net.
|
@TravisEz13 please re-review |
|
/cc @bergmeister for information. |
|
🎉 Handy links: |
PR Summary
Script to help to move to the next preview version of .NET. The version of .NET is in DotnetRuntimeMetadata.json.
The script is to be used by developer who wants to move the code base to the new .NET preview. The script will update the global.json and all the other csproj files which need to be updated.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.