Fix erroneous comment in tokenizer.cs #12206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BigInteger NumberSuffixFlags enum is 'N', not 'I'. Fix the comment to indicate it as such.
vexx32
approved these changes
Mar 26, 2020
Collaborator
There was a problem hiding this comment.
I've been meaning to come back and fix that, but I kept forgetting! 😂
Thanks for sorting this out! 💖
iSazonov
approved these changes
Mar 26, 2020
Collaborator
|
@ShaydeNofziger Thanks for your contribution. |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch t
3153
hat can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix erroneous comment -- the BigInteger NumberSuffixFlags enum is 'N', not 'I'.
PR Summary
Fixing a documentation issue as mentioned in #10152
PR Context
As indicated on line 4022 of tokenizer.cs and in the linked Issue related to this PR, BigInteger is represented by the 'N' suffix, not 'I'.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.