Add Modules from the PowerShell/Modules Repo to the tracked modules list #12183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding additional Microsoft-owned modules to be tracked at load time in the PowerShell 7 telemetry.
Updating to include non-gallery modules queried from Microsoft Docs.
Co-Authored-By: Joey Aiello <joeyaiello@users.noreply.github.com>
updating my fork
Add Microsoft.PowerShell.SecretManagement to the tracked module list.
Added: - Microsoft.PowerShell.TextUtility - Microsoft.PowerShell.RemotingTools
Collaborator
|
Is it for 7.0-Servicing? |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Collaborator
|
@JamesWTruher @SteveL-MSFT Can you approve the change? |
JamesWTruher
approved these changes
Oct 15, 2020
Collaborator
|
@SydneyhSmith Please rebase to pass CIs. |
SteveL-MSFT
approved these changes
Oct 15, 2020
Member
|
We should take this for 7.1 to track SecretManagement usage and it's also low risk. |
adityapatwardhan
approved these changes
Oct 19, 2020
Member
|
Re-opening to restart CI |
Member
|
@SydneyhSmith Should we also add |
Adds Microsoft.PowerShell.SecretStore
adityapatwardhan
approved these changes
Oct 19, 2020
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Modules from the PowerShell/Modules Repo to the tracked modules list:
PR Context
Since we have released a new module, I am adding it to the list of modules we are interested in tracking.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.