Move to .NET 5 preview.1
#12140
Move to .NET 5 preview.1
#12140
Conversation
|
It looks like there's an issue in .NET 5 preview1 where we set the main thread name and that somehow gets propagated as the process name on Linux (only) and so tests that check if it's pwsh ends up failing. I'll see about putting in some reasonable workarounds for now and add a pending test to verify the process name. |
There was a problem hiding this comment.
I've looked at the changes so far
|
.NET 5 specifically has improvements to regex, so needed to increase the size of the DOS test |
|
On Windows, pwsh is crashing in a native API call. Opened dotnet/runtime#33703 |
cc @stephentoub 👏 |
@SteveL-MSFT is that a bug in .NET? |
|
@danmosemsft The main thread name becoming the process name is a bug in .NET and is understood (dotnet/runtime#33673). That issue isn't blocking as it's currently only affecting tests and I made changes to work around it. The crashing issue (dotnet/runtime#33703) is preventing us from moving to .NET 5. Thanks! |
|
There is already an issues filed for regex DOS tests: #12138 |
Remove assembly from startup validation
|
@PoshChan retry macos |
|
@SteveL-MSFT, successfully started retry of |
test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
Show resolved
Hide resolved
|
.NET originally said that the perf improvement was due to optimization, but it's actually due to a bug. I filed an issue to add it back to avoid delaying this PR. |
It's half and half :) The algorithmic complexity improved, in part due to perf improvements, and in part due to a bug fixed in Preview 2 (dotnet/runtime#33409). |
|
🎉 Handy links: |
PR Summary
Updated associated build files to netcoreapp5.0 and ref assemblies to 5.0-preview.1 where applicable. Updated files.wxs to changes.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.